Changes between Initial Version and Version 1 of Ticket #13839, comment 11
- Timestamp:
- Apr 6, 2016, 11:31:35 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13839, comment 11
initial v1 1 Ok, I've moved whole fix into radio type . The code is _de facto_duplicated version of [https://github.com/ckeditor/ckeditor-dev/blob/b6664099c0499b517a7ce0bb64e41b2716d5fd90/plugins/dialog/plugin.js#L2468-L2485 code in `plugins/dialog/plugin.js`] that adds focus to the input element.1 Ok, I've moved whole fix into radio type definition. The code is ''de facto'' duplicated version of [https://github.com/ckeditor/ckeditor-dev/blob/b6664099c0499b517a7ce0bb64e41b2716d5fd90/plugins/dialog/plugin.js#L2468-L2485 code in `plugins/dialog/plugin.js`] that adds focus to the input element. 2 2 3 3 The issue with radiobutton group seems to be caused by the fact that dialog assumes there is always only one input element in the dialog's UI element, therefore not all event listeners were added and `focus` event was not properly propagated. The second part of the issue was caused by the fix for #10866 (which fixed the effect of already mentioned issue without fixing the cause of it) and adding focus to all radiobuttons separately instead of adding focus to the whole group.