Changes between Initial Version and Version 1 of Ticket #16682, comment 18


Ignore:
Timestamp:
Dec 23, 2016, 11:04:32 PM (3 years ago)
Author:
Marek Lewandowski
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16682, comment 18

    initial v1  
    33So the thing is that this fixture produces an edge case `magin:0`, which made `val` equal to 0 [https://github.com/cksource/ckeditor-dev/blob/39e58ab/plugins/pastefromword/filter/default.js#L1662 inside of levels lookup map] having levels equal to 0 it was messing up the transformations later on.
    44
    5 The fix here is to [https://github.com/cksource/ckeditor-dev/blob/39e58ab/plugins/pastefromword/filter/default.js#L1666-L1670 bump _every_ level]if a case like this happens.
     5The fix here is to [https://github.com/cksource/ckeditor-dev/blob/39e58ab/plugins/pastefromword/filter/default.js#L1666-L1670 bump every level] if a case like this happens.
    66
    77I've added proper integration and unit test for this. Also there's an integration test for negative margins (which are possible to create in Word).
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy