Changes between Initial Version and Version 1 of Ticket #5217, comment 35


Ignore:
Timestamp:
Mar 3, 2014, 12:59:52 PM (6 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5217, comment 35

    initial v1  
    11I pushed few additional commits to recovered branch:t/5217 branch.
    22
    3 1. First of all I found out that [https://github.com/ckeditor/ckeditor-dev/blob/c98c7a9/core/selection.js#L778 this] is not needed any more. I added a TC for it.
    4 2. Then I added a `unlockSelection` call on `setData`. This fixed comment:34, comment:32 (#11585, although I'm not able to reproduce it now even on `branch:t/5217~2` :|) and #11500.
     31. First of all I found out that [https://github.com/ckeditor/ckeditor-dev/blob/c98c7a9/core/selection.js#L778 this listener] is not needed any more. I added a missing TC for #7174.
     42. Then I added an `unlockSelection` call on `setData`. This fixed comment:34, comment:32 (#11585, although I'm not able to reproduce it now even on `branch:t/5217~2` :|) and #11500.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy