Opened 10 years ago

Last modified 10 years ago

#6395 review_failed Bug

Unable to set formating on empty page — at Version 9

Reported by: Krzysztof Studnik Owned by: Martin
Priority: Normal Milestone:
Component: Core : Styles Version: 3.4.1
Keywords: Opera Cc:

Description (last modified by Martin)

Found when checking #6370 In Opera

  • set new empty page
  • set text formating as "Formated"
  • enter some text - formating is back to normal
  • set formating again - enetered text format changes itself (video)
  • result in CKE3.4.1

{{{{ <pre> test<span style="display: none">&nbsp;</span></pre> <pre> <span style="display: none">&nbsp;</span> </pre> }}} The same test case in CKE 3.4

<pre>
<span _fck_bookmark="1" style="display: none">&nbsp;</span>test</pre>
<pre>
<span _fck_bookmark="1" style="display: none">&nbsp;</span>
</pre>
}}}[[BR]]
[[BR]]
[[BR]]

Change History (11)

Changed 10 years ago by Krzysztof Studnik

Attachment: krst 15.56.15 .avi added

comment:1 Changed 10 years ago by Garry Yao

Milestone: CKEditor 3.4.2

pre-formatted style is not opened properly, while other blocks are good, the cursor is not blinking after applying them.

comment:2 Changed 10 years ago by Garry Yao

Status: newconfirmed

comment:3 Changed 10 years ago by Garry Yao

Let's first get #6282 fixed.

comment:4 Changed 10 years ago by Paweł Horzela

Owner: set to Paweł Horzela
Status: confirmedassigned

comment:5 Changed 10 years ago by Martin

Owner: changed from Paweł Horzela to Martin

Changed 10 years ago by Martin

Attachment: 6395.patch added

Patch

comment:6 Changed 10 years ago by Martin

Status: assignedreview

comment:7 Changed 10 years ago by Garry Yao

Status: reviewreview_failed

@mani Ah...hard to believe this is a fix...the 'newBlock' may have contents from existing blocks.

comment:8 Changed 10 years ago by Garry Yao

I think you'll need to briefly explain a bit the cause behind such a fix.

comment:9 Changed 10 years ago by Martin

Description: modified (diff)

Look at the code:

//document.body.contentEditable = false
document.designMode = 'on';

var sel = window.getSelection();
sel.removeAllRanges();


It is not working but should but when we uncomment first line and comment second everythink works. Additionaly I can say when designMode == 'on', sel.AddRange() don`t work too so we can not modify selection.

Maybe this will be some tip to others.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy