Changes between Initial Version and Version 1 of Ticket #9981, comment 4


Ignore:
Timestamp:
Jan 23, 2013, 7:19:36 PM (7 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9981, comment 4

    initial v1  
    11Unfortunately this was broken from the very beginning. My changes in this branch just fixed the filter so it applies filter as long as name is changed - exactly like for {{{elementNames}}}.
    22
    3 When writing tests for #9972 I found also this weird behaviour that string is used as a replace() pattern, so it doesn't mean full match. Initially I also found this completely wrong. But then I checked if there's a chance to fix it without affecting performance and I think that it'd better to leave this simple mechanism. First element in array is used as a replace pattern (replace() accepts string and regexp), second element as replacement. That's all.
     3When writing tests for #9972 I also found this weird behaviour that string is used as a replace() pattern, so it doesn't mean full match. Initially I also found this completely wrong. But then I checked if there's a chance to fix it without affecting performance and I think that it'd better to leave this simple mechanism. First element in array is used as a replace pattern (replace() accepts string and regexp), second element as replacement. That's all.
    44
    5 What's more - our code isn't using string pattern (only one usage in htmlDataProcessor, but rather safe). Instead, it uses regexp correctly.
     5What's more - our code doesn't use string pattern (only one usage in htmlDataProcessor, but rather safe). Instead, it uses regexp correctly.
    66
    77So, I'm to leave this as expected behaviour. This is how it worked, this is fast and the only wrong thing is that it wasn't documented so it may be a little confusing.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy