Changes between Initial Version and Version 1 of Ticket #9981, comment 4
- Timestamp:
- Jan 23, 2013, 7:19:36 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #9981, comment 4
initial v1 1 1 Unfortunately this was broken from the very beginning. My changes in this branch just fixed the filter so it applies filter as long as name is changed - exactly like for {{{elementNames}}}. 2 2 3 When writing tests for #9972 I found alsothis weird behaviour that string is used as a replace() pattern, so it doesn't mean full match. Initially I also found this completely wrong. But then I checked if there's a chance to fix it without affecting performance and I think that it'd better to leave this simple mechanism. First element in array is used as a replace pattern (replace() accepts string and regexp), second element as replacement. That's all.3 When writing tests for #9972 I also found this weird behaviour that string is used as a replace() pattern, so it doesn't mean full match. Initially I also found this completely wrong. But then I checked if there's a chance to fix it without affecting performance and I think that it'd better to leave this simple mechanism. First element in array is used as a replace pattern (replace() accepts string and regexp), second element as replacement. That's all. 4 4 5 What's more - our code isn't usingstring pattern (only one usage in htmlDataProcessor, but rather safe). Instead, it uses regexp correctly.5 What's more - our code doesn't use string pattern (only one usage in htmlDataProcessor, but rather safe). Instead, it uses regexp correctly. 6 6 7 7 So, I'm to leave this as expected behaviour. This is how it worked, this is fast and the only wrong thing is that it wasn't documented so it may be a little confusing.
