Tableresize plugin is not integrated with undo manager

[Prem]

When table cells are re-sized with the mouse, cells are re-sized but when we save the CkEditor data is not updated with the new cell widths. Tableresize plugin not firing change event.

we need to call editor.fire('change') for this to work properly in the init function

---

Edit: The goal is that resizing was undoable and that the #change event was fired once user _finishes_ resizing.

[Jakub Ś]

Could you tell me which table resize plugins you are talking about? Is it native table resize (available in IE and FF) or CKSource resize which allows resizing table columns?

In case of native resize this is a duplicate of #10979. In case of CKEditor resize this is valid ticket.

Please tell us which feature you are talking about.

[Prem]

Hi, It is a native resize that is available in ​http://ckeditor.com/addon/tableresize.

[Piotrek Koszuliński]

By "native" we mean features/behaviours implemented by browsers or OS. The tableresize plugin is a JS plugin, so it is not a native behaviour.

Anyway, I confirm that the tableresize plugin does not fire snapshots so it is not integrated with undo manager at all. And it is undo manager who fires the #change event.

[Szymon Cofalik]

Fixed pushed to ​branch:t/13388

[Szymon Cofalik]

Rebased ​branch:t/13388 with major.

[Piotrek Koszuliński]

I pushed two more commits to the branch.

In one of them you will find a manual test which didn't pass (typing was part of resizing's undo step). In the second commit there's how I think the code should look like. If you agree, please write an automated test for it. The way how we simulate typing is that we simply set innerHTML of some element (table cell in this case). It will be enough for this test.

[Szymon Cofalik]

There was already a unit test, but I improved it.

Rebased with master and pushed ​branch:t/13388

[Olek Nowodziński]

I pushed a commit to ​branch:t/13388 and rebased in on master.

The fix is OK. But it looks like the scenario of MT is wrong as it passes both on master and ​branch:t/13388. Only when I repeat 2. and 3. a couple of times, the bug is reproducible. You can extend the existing scenario or suggest something totally different.

[Szymon Cofalik]

Pushed ​branch:t/13388

I expanded current test.

[Olek Nowodziński]

Merged ​git:730e54b into master.