editor.getData() fails, when cursor is next to a HR tag

[wginolas]

1. Configure a inline CKEditor with the Sourcedialog plugin enabled.
2. Visit this editor with Chrome.
3. Enter this content via the Sourcedialog plugin:

   <hr />
   

4. Open the Sourcedialog right after you closed it.
5. The dialog is empty and the following exception is thrown:

   Uncaught IndexSizeError: Failed to execute 'extend' on 'Selection': 1 is larger than the given node's length.
   moveNativeSelectionToBookmark @ selection.js:224
   afterData @ selection.js:895
   listenerFirer @ event.js:144
   CKEDITOR.event.fire @ event.js:290
   CKEDITOR.editor.fire @ editor_basic.js:24
   CKEDITOR.tools.extend.getData @ editor.js:880
   onShow @ sourcedialog.js:24
   listenerFirer @ event.js:144
   CKEDITOR.event.fire @ event.js:290
   (anonymous function) @ plugin.js:878
   (anonymous function) @ tools.js:464
   

I do not fully understand, what is happening here, but the Souredialog plugin calls editor.getData() when the dialog is opened. This call fails.

[Jakub Ś]

Problem can be reproduced from CKEditor 4.4.6 in Blink browsers only.

Error is:Uncaught IndexSizeError: Failed to execute 'extend' on 'Selection': 1 is larger than the given node's length.
Message:
Line: 224
URI: core/selection.js
Code: sel.extend( bm[ 1 ].node, bm[ 1 ].offset );

[Artur Delura]

There are three related issues: #13389 #13307 #13284

[Jonathan]

Also related to issue ​#13513

[kkrzton]

This issue is also related to #13816 which is reimplementation of Filling Character handling mechanism.

I switched to ​t/13816 and perform some tests for this particular issue. The #13816 fixes also this issue so if #13816 is planned to be released also in 4.5.7 milestone there is no need to do some additional fixes for this issue.

I will provide automatic tests to cover this issue.

[kkrzton]

Provided unit tests, changes in ​t/13389.

At the moment tests fails on Chrome. Test passes with #13816 (which fixes this issue) so this branch should be merged after #13816.

[Marek Lewandowski]

Fixed with ​git:2d078ff42a by #13816.