Ticket #1633 (closed Bug: fixed)

Opened 7 years ago

Last modified 6 years ago

[FF] styles on iframe elements affect the editor and panels

Reported by: alfonsoml Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.1
Component: General Version: FCKeditor 2.5.1
Keywords: Confirmed Firefox Review+ Cc:

Description

Add

	<style type="text/css">
		iframe {
			width: 100%;
			height: 400px;
			border: 3px solid red;
			background-color: blue;
		}
	</style>

to a test page and you'll see that they make impossible to use the editor. I think that we should force some styles on the generated iframes to avoid this kind of problems.

Reported in http://www.fckeditor.net/forums/viewtopic.php?f=6&t=7759

Attachments

1633_pre.patch (4.8 KB) - added by martinkou 6 years ago.
1633.patch (5.3 KB) - added by martinkou 6 years ago.
1633_2.patch (5.4 KB) - added by martinkou 6 years ago.

Change History

comment:1 Changed 7 years ago by w.olchawa

  • Keywords Confirmed Firefox added
  • Version set to SVN
  • Summary changed from styles on iframe elements affect the editor and panels to [FF] styles on iframe elements affect the editor and panels

Confirmed in FF. Works in IE.

The big occurs in stable 2.5.1 and in the SVN version.

comment:2 Changed 7 years ago by w.olchawa

The *big occurs in stable 2.5.1 and in the SVN version.

  • THE BUG :)

comment:3 Changed 6 years ago by alfonsoml

  • Version changed from SVN to FCKeditor 2.5.1

comment:4 Changed 6 years ago by fredck

  • Milestone set to FCKeditor 2.6.1

As pointed by Alfonso, the solution for #1948 could be generalized to fix this one too.

comment:5 Changed 6 years ago by martinkou

  • Status changed from new to assigned
  • Owner set to martinkou

comment:6 Changed 6 years ago by martinkou

I've written a patch such that the editor iframe and floating panels in sample*.html are not longer affected by external styles. However, I've noticed that the changes would touch the integration code in $FCKeditor/fckeditor.<lang> files, and I've only changed the fckeditor.js file for that.

Changed 6 years ago by martinkou

comment:7 Changed 6 years ago by martinkou

My test case for the page:

        <style type="text/css">
                iframe {
                        width: 500px;
                        height: 400px;
                        border: 3px solid red;
                        background-color: blue;
                        padding: 20px;
                        margin: 20px;
                }
        </style>

Changed 6 years ago by martinkou

comment:8 Changed 6 years ago by martinkou

  • Keywords Review? added

I've found a way to reset the styles of the editor iframe without modifying any integration code. The updated patch is ready for review.

comment:9 Changed 6 years ago by alfonsoml

  • Keywords Review- added; Review? removed

the

/^\d+$/.test( width ) && ( width += 'px' ) ; 
/^\d+$/.test( height ) && ( height += 'px' ) ; 

code seems too complex, I think that it's easier to understand it this way (if I have understood properly the code)

 if (/^\d+$/.test( width ) ) width += 'px' ; 
 if (/^\d+$/.test( height ) ) height += 'px' ; 

also, instead of naming the variable "sy" you could name it "style", it will be compressed anyway, so there's no need to do it right now.

Changed 6 years ago by martinkou

comment:10 Changed 6 years ago by martinkou

  • Keywords Review? added; Review- removed

Updated patch according to suggestions.

comment:11 Changed 6 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

comment:12 Changed 6 years ago by martinkou

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [1950].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy