Opened 9 years ago

Closed 8 years ago

#2065 closed Bug (fixed)

Floating dialogs fail to block editing area focus when Tab key is pressed

Reported by: martinkou Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.1
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:


To reproduce the bug:

  1. Open _samples/html/sample01.html included in the latest SVN trunk in IE or Firefox.
  2. Open any floating dialog window, e.g the Smiley dialog.
  3. Press Tab on the keyboard until the focus shifts to the editing area.
  4. Once the focus goes to the editing area, you find that you can edit the "inactive" document again.

This bug is pretty obvious to users who are used to switching UI widget focus via the Tab key so it should block the final 2.6 release.

Attachments (2)

2065.patch (1.5 KB) - added by martinkou 9 years ago.
2065_2.patch (1.6 KB) - added by martinkou 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by martinkou

  • Cc Confirmed removed
  • Keywords Confirmed added

Changed 9 years ago by martinkou

comment:2 Changed 9 years ago by martinkou

  • Keywords Review? added

comment:3 Changed 9 years ago by fredck

  • Milestone changed from FCKeditor 2.6 to FCKeditor 2.6.1

In a RC, only extremely critical tickets should be included for the final. This one is a normal bug, which can safely enter in our normal release schedule. I'm retargeting it.

comment:4 Changed 8 years ago by alfonsoml

  • Keywords Review- added; Review? removed

I never have tried it, but I think that some people have reported in the forums about how to adjust the tab order of the editor, so they end up setting the tabIndex, and with this patch that info will get lost.

I mean: instead of just setting and removing the tabIndex, I suggest to store its current value and then restore it. Is it worth?

Changed 8 years ago by martinkou

comment:5 Changed 8 years ago by martinkou

  • Keywords Review? added; Review- removed
  • Status changed from new to assigned

I've updated the patch to save the previous tabIndex value to restore it after all dialogs are closed.

comment:6 Changed 8 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

comment:7 Changed 8 years ago by martinkou

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [1944].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy