Ticket #2263 (closed Bug: fixed)

Opened 7 years ago

Last modified 6 years ago

Editor - anchor - java script error

Reported by: gobinathb Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.3
Component: General Version: FCKeditor 2.6
Keywords: Confirmed IE Review+ Cc: gobinath@…

Description

Click the anchor button and give the name as test.then click source button.then return back from source(reclicking that source button).then click only one time undo button.then click source button.that time java script error is occoured.This problem only in ie. Firefox is having no problem

Attachments

cas_anchor.html (49 bytes) - added by gobinathb 7 years ago.
2263.patch (3.1 KB) - added by martinkou 6 years ago.

Change History

Changed 7 years ago by gobinathb

comment:1 Changed 7 years ago by martinkou

  • Priority changed from High to Normal
  • Keywords Confirmed IE added; Anchor Bug removed

Confirmed the problem.

comment:2 follow-up: ↓ 3 Changed 7 years ago by fredck

  • Milestone FCKeditor 2.6.1 deleted

comment:3 in reply to: ↑ 2 Changed 7 years ago by gobinathb

Replying to fredck:

could u tell tell me where the problem of that?

comment:4 Changed 7 years ago by martinkou

2.6.1 is nearing release, so new and non-critical tickets are being re-targeted away from it.

comment:5 follow-up: ↓ 6 Changed 7 years ago by gobinathb

still i have problem with anchor tag.Could i confirm it with you in new release?

comment:6 in reply to: ↑ 5 Changed 6 years ago by gobinathb

sorry for inconvenience. please tell me where i have to change the source to rectify this problem?i need to solve this problem.

comment:7 Changed 6 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

Changed 6 years ago by martinkou

comment:8 Changed 6 years ago by martinkou

  • Keywords Review? added

comment:9 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:10 Changed 6 years ago by martinkou

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [2139].

Click here for more info about our SVN system.

comment:11 Changed 6 years ago by Scott

Hello,

The fix for #2263 is breaking source protection in IE SVN nightly. http://dev.fckeditor.net/ticket/2263

Basically the elements array is completely nulled out.

ToElements : function() {

var node = FCK.EditorDocument.createElement( 'div' ) ; for ( var i = 0 ; i < this.Elements.length ; i++ ) {

if ( typeof( this.Elements[i] ) == 'string' ) {

node.innerHTML = this.Elements[i] ; this.Elements[i] = node.firstChild ; <--------- This line node.firstChild is null

}

}

}

To replicate, visit http://www.fckeditor.net/nightly/fckeditor/_samples/default.html Click source Add <!-- test --> to the source, Press Source again to revert to design mode Press Source again, and you have a "null" cannot be null

comment:12 Changed 6 years ago by Scott

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:13 Changed 6 years ago by fredck

  • Milestone set to FCKeditor 2.6.3

comment:14 Changed 6 years ago by fredck

  • Status changed from reopened to closed
  • Resolution set to fixed

@Scott, I've opened a dedicated ticket for it: #2368.

comment:15 Changed 6 years ago by alfonsoml

This patch has caused #2411

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy