Ticket #2266 (closed Task: fixed)

Opened 6 years ago

Last modified 6 years ago

FCKeditor extension for MediaWiki doesn't follow MW's coding conventions

Reported by: Jack Phoenix Owned by:
Priority: Low Milestone:
Component: Project : MediaWiki+FCKeditor Version: SVN (FCKeditor) - Retired
Keywords: Confirmed HasPatch Cc:

Description

FCKeditor extension for MediaWiki doesn't seem to be following MediaWiki's coding conventions as described in http://www.mediawiki.org/wiki/Manual:Coding_conventions.

For example, FCKeditorEditPage.body.php had this in two separate lines:

class FCKeditorEditPage extends EditPage
{

when it should've been just one line as per MW's coding conventions:

class FCKeditorEditPage extends EditPage {

The extension credits ($wgExtensionCredits) in FCKeditor.php seem to be out-of-date and using "double quoting" (i.e. "name" => "FCKeditor", and so on) when 'single quoting' would be OK. I've created a patch against the current SVN version to fix these minor issues, let's see if I can attach it here... ;-)

Attachments

FCKed.patch (17.1 KB) - added by Jack Phoenix 6 years ago.
Patch to make the FCKeditor use standard coding style & updated $wgExtensionCredits with more accurate info

Change History

Changed 6 years ago by Jack Phoenix

Patch to make the FCKeditor use standard coding style & updated $wgExtensionCredits with more accurate info

comment:1 Changed 6 years ago by w.olchawa

  • Priority changed from Normal to Low
  • Keywords Confirmed HasPatch added

This fortunately is a minor bug.

comment:2 Changed 6 years ago by wwalc

  • Status changed from new to closed
  • Resolution set to fixed

Thanks, fixed with [2077].

It's hard to follow strictly MediaWiki coding conventions, so let's just try to be constant and that should be enough. For javascript code, FCKeditor coding style is preferred: Coding Style Guidelines.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy