Opened 17 years ago
Closed 17 years ago
#2320 closed Bug (fixed)
FF3: Find/Replace scrolls the entire page
| Reported by: | Frederico Caldeira Knabben | Owned by: | Martin Kou |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.3 |
| Component: | General | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed Firefox3 IE Review+ | Cc: |
Attachments (2)
Change History (10)
comment:1 Changed 17 years ago by
| Milestone: | → FCKeditor 2.6.3 |
|---|---|
| Owner: | set to Martin Kou |
| Status: | new → assigned |
Changed 17 years ago by
| Attachment: | 2320.patch added |
|---|
comment:2 Changed 17 years ago by
| Keywords: | IE added |
|---|
comment:3 Changed 17 years ago by
| Keywords: | Review? added |
|---|
comment:4 Changed 17 years ago by
Everything looks good... just the fix at line 997 can be simplified:
- offset += parseInt( this.GetCurrentElementStyle( element, 'marginBottom' ) || 0, 10 ) ; + offset += parseInt( this.GetCurrentElementStyle( element, 'marginBottom' ) || 0, 10 ) || 0 ;
Review+ with the above change.
comment:5 Changed 17 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Changed 17 years ago by
| Attachment: | 2320_2.patch added |
|---|
comment:6 Changed 17 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:7 Changed 17 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:8 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed with [2159].
Click here for more info about our SVN system.

The problem happens in IE as well.
I changed the scrollIntoView() to FCKDomTools.ScrollIntoView(), as usual. But I've also made some changes to FCKDomTools.ScrollIntoView() to make it work correctly in IE, the current version doesn't work in IE because the scrolling coordinate it calculates becomes NaN.