Opened 8 years ago

Closed 8 years ago

#2430 closed New Feature (fixed)

Support THEAD in Tables

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.4
Component: General Version: FCKeditor 2.3.2
Keywords: Review+ Cc:

Description

Attachments (6)

fck_table.html (15.9 KB) - added by alfonsoml 8 years ago.
Previous patch
2430.patch (8.2 KB) - added by alfonsoml 8 years ago.
Updated patch
2430_2.patch (48.8 KB) - added by alfonsoml 8 years ago.
new patch
2430_3.patch (46.8 KB) - added by alfonsoml 8 years ago.
Revised patch
2430_4.patch (47.2 KB) - added by alfonsoml 8 years ago.
new patch
2430_5.patch (47.1 KB) - added by alfonsoml 8 years ago.
adjustement in the RenameNode function

Download all attachments as: .zip

Change History (16)

Changed 8 years ago by alfonsoml

Previous patch

Changed 8 years ago by alfonsoml

Updated patch

comment:1 Changed 8 years ago by alfonsoml

I've updated the patch, fixing the issues that it had with IE and using some of the new FCKDomTools functions.

It's still missing the text entries in the language files and the corresponding what's new, but it should be enough to check that the code works as expected.

Does anyone have any suggestion or problem related to this patch?

Changed 8 years ago by alfonsoml

new patch

comment:2 Changed 8 years ago by alfonsoml

  • Keywords Review? added

I've modified the patch including the language files, and I've changed the UI, instead of using two checkboxes I think that it might be easier for the user to have a single select box with the available combination of headers.

I see that I've forgot about the what's new entry, it should be something like: New features: In the table dialog it's possible to create header cells in the first row (included in a thead element) or the first column of the table.

comment:3 Changed 8 years ago by martinkou

  • Keywords Review- added; Review? removed

The patch has a few problems that need to be fixed:

  1. Create a default 2x3 table -> open table properties to set its first column to header -> open the table properties dialog again to set its first row to header. You'll see the top-left cell of the table remains a regular <td> cell. The culprit here is line 234 to line 242 in fck_table.html.
  2. Line 196 should be th.scope = 'row' instead of th.scope = 'col', right?
  3. The function FCKDomTools.RenameNode() is only used by fck_table.html so far. It seems to be more appropriate to define it inside fck_table.html to reduce core code size.
  4. The changes to fckconfig.js shouldn't be in the patch.

Changed 8 years ago by alfonsoml

Revised patch

comment:4 Changed 8 years ago by alfonsoml

  • Keywords Review? added; Review- removed
  1. I've changed the logic so it only changes cells inside the tbody element(s).
  2. I think that line 196 was right, the problem was line 229, so that it matches the scopes generated if the headers are set at creation time.
  3. The idea is to reuse the function for the cell dialog to switch between td and th, but I've moved to fck_dialog_common.js so it isn't in the core anymore.
  4. Sorry, I didn't see it. I've attached the what's new changes this time.

comment:5 Changed 8 years ago by alfonsoml

  • Keywords Review? removed

ups, now something it's failing in IE...

Changed 8 years ago by alfonsoml

new patch

comment:6 Changed 8 years ago by alfonsoml

  • Keywords Review? added

I've fixed a big problem in IE that placed the TH at the end of the row, and a little detail in Opera that sometimes it did include an extra empty <tbody>

Changed 8 years ago by alfonsoml

adjustement in the RenameNode function

comment:7 Changed 8 years ago by alfonsoml

I've started looking at the TH option for the cell dialog and based on the previous patch by Martinkou I've remembered that now I can use the existing function to copy all attributes properly.

comment:8 Changed 8 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:9 Changed 8 years ago by martinkou

  • Milestone set to FCKeditor 2.6.4

comment:10 Changed 8 years ago by alfonsoml

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with [2362]

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy