Option 'Match cyclic' not working

[Garry Yao]

The config option of Match cyclic which should restart the search from the beginning of document which doesn't work.
Reproducing procedure:

1. Open Replace by code sample;
2. Make selection as below:

   <p>This i^s some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
   

3. Open the find/replace dialog, make sure only the match cyclic option is checked, fill in is in 'Find what' input, then click find button.
4. Prompted with '...text not found', click find button again.

• Expected result: The document is highlighted as

  <p>Th^is^ is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
  
  

• Actual result: Again prompted '...text not found'.

[Martin Kou]

The bug isn't reproducible outright, but after repeating the procedure a few times does trigger it.

[Frederico Caldeira Knabben]

#2985 has been marked as DUP

[Martin Kou]

The bug is caused by line 485 of the Find dialog file. It resets the search position to the position of the selection before the dialog is opened after the find reached the end of document. That's wrong. It should reset the search position back to the start of the document instead.

[Martin Kou]

Fixed with [3167].

Click here for more info about our SVN system.