Ticket #3009 (closed Bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Enhance testing framework to support async 'setUp'

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: QA Version: 3.0 Beta 2
Keywords: Confirmed HasTest Cc:

Description (last modified by garry.yao) (diff)

In functional tests where always requires to have a fully interacted editor instance as prerequisites, with all tests in a case share a 'playground' instance.

We should provide a customized TestSuite which responsible for setting up a editor instance transparently with all containing TCs share this singleton, with this, it even able to make sure each test 's cleanness in a TC by resetting the editor with TestCase::setUp.

Since the setting up of our editor is always an asynchronous operation, so does cleaning up an editor sometimes, sadly that YUI doesn't support calling wait/resume inside setUp method, we should work around it in order to bring the above functionality into truth.

Attachments

3009.patch (3.9 KB) - added by garry.yao 5 years ago.
3009_2.patch (2.7 KB) - added by garry.yao 5 years ago.
3009_3.patch (3.9 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned
  • Keywords Confirmed added

comment:2 Changed 5 years ago by garry.yao

  • Description modified (diff)

Revised to a new approach to work arround this.

Changed 5 years ago by garry.yao

comment:3 Changed 5 years ago by garry.yao

  • Keywords Review? added

comment:4 Changed 5 years ago by fredck

  • Component changed from General to QA
  • Milestone CKEditor 3.0 deleted

comment:5 Changed 5 years ago by alfonsoml

  • Version changed from SVN (FCKeditor) to CKEditor 3.0 Beta 2

comment:6 Changed 5 years ago by garry.yao

  • Keywords HasPatch added; Review? removed
  • Milestone set to CKEditor 3.1

The correct way is having a dedicated 'YAHOO.tool.TestSuite' instead of 'YAHOO.tool.TestCase', any editor based TCs should be grouped into it.

Changed 5 years ago by garry.yao

comment:7 Changed 5 years ago by garry.yao

  • Keywords HasTest Review? added; HasPatch removed

comment:8 Changed 5 years ago by garry.yao

  • Description modified (diff)

Update description according to recent investigation.

Changed 5 years ago by garry.yao

comment:9 Changed 5 years ago by garry.yao

The new path contains the following changes:

  1. Enable 'wait/resume' support in 'setUp' for both TestSuite/TestCase;
  2. Decouple YUI Test enhancement to dedicated YUI extension.
  3. Update TC with [4106].

comment:10 Changed 5 years ago by garry.yao

  • Keywords Review? removed

Changes committed with [4147] at CKEditor and [4148] at CKTester.

comment:11 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy