Justify across table cells incorrect

[Garry Yao]

Reproducing Procedures

1. Open the replace by class example page;
2. Make the following content with the selection by click and drag over table cells;

   <table border="1" cellpadding="1" cellspacing="1" style="width: 200px;">
   	<tbody>
   		<tr>
   			^<td>
   				text</td>
   			<td>
   				text</td>^
   		</tr>
   	</tbody>
   </table>
   

3. Click on 'Justify Right' to apply alignment.
   • Actual Result: Javascript Error occurred.
   • Expected Result:

     <table>
     	<tbody>
     		<tr>
     			<td style="text-align: right;">
     				text</td>
     		</tr>
     		<tr>
     			<td style="text-align: right;">
     				text</td>
     		</tr>
     	</tbody>
     </table>
     

[Garry Yao]

Update the Expected Result of this TC.

[Garry Yao]

Two updates:

1. Skip bookmark nodes in the following case which are harmful for the iterating:

   <table _moz_resizing="true">
       <tbody>
           <tr>
               <span _fck_bookmark="1" style="display: none;"> </span>
               <td>
                   text
               </td>
               <span _fck_bookmark="1" style="display: none;"> </span>
           </tr>
       </tbody>
   </table>
   

2. Make the justify style happen on multiple ranges instead of only the first.

[Frederico Caldeira Knabben]

I've tested it over a table with three columns. If I select two rows of it, and then align right, only the cells at the left get aligned and a js error is thrown.

[Garry Yao]

It's again a matter of multiple ranges mangled by bookmark creation process.

[Garry Yao]

Reflecting the latest patch from #3475 for easy reviewing.

[Frederico Caldeira Knabben]

Maybe a simpler solution could be found, which would avoid making that many changes to the code. It should be possible to fix the ranges when creating the bookmarks, so all necessary changes could go on createBookmarks only.

[Garry Yao]

Use an less obtrusive way to update the affected ranges inspired by Fred.

[Frederico Caldeira Knabben]

The idea and even the implementation is quite good. As discussed with Garry we could just try simplifying it further. We've coded it at four hands and a new patch should come soon.

[Martin Kou]

Please fix the minor style problems in L80 of _source/plugins/justify/plugin.js before committing - binary operators should have spaces around them, and block brackets should occupy their own lines. So it should look like this:

            for ( var i = ranges.length - 1 ; i >= 0 ; i-- )
            {

[Garry Yao]

Fixed with [3662].