Opened 16 years ago
Closed 15 years ago
#3257 closed Bug (fixed)
List doesn't preserve block style
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | Core : Lists | Version: | SVN (CKEditor) - OLD |
Keywords: | Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the replace by class example page;
- Open 'Format' combo and select 'Heading 1' style;
- Click on 'Numbered List' to apply list format;
- Actual Result:
<ol> <li> This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</li> </ol>
- Expected Result:
<ol> <li> <h1> This is some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</h1></li> </ol>
- Actual Result:
Attachments (2)
Change History (11)
comment:1 Changed 16 years ago by
Priority: | High → Normal |
---|
comment:2 Changed 16 years ago by
Milestone: | CKEditor 3.0 → CKEditor 3.x |
---|
comment:3 Changed 15 years ago by
Component: | General → Core : Lists |
---|---|
Version: | → SVN (CKEditor) |
comment:4 Changed 15 years ago by
Milestone: | CKEditor 3.x → CKEditor 3.3 |
---|
The duplicate defect #5271 had this as 3.3. Moving this milestone to 3.3 also. We need to understand the status of this issue.
Changed 15 years ago by
Attachment: | 3275.patch added |
---|
comment:5 Changed 15 years ago by
Keywords: | Confirmed Review? added |
---|---|
Owner: | set to Garry Yao |
Status: | new → assigned |
comment:6 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
I'm not sure, but maybe a simpler logica can be found for this one:
if contentBlock is header remove contentBlock and append it to listItem else append the contentBlock children to listItem and remove it
Am I wrong?
Changed 15 years ago by
Attachment: | 3257_2.patch added |
---|
comment:7 follow-up: 8 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
You're neat, so how about inherit the block styles to list item also?
comment:8 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
Replying to garry.yao:
You're neat, so how about inherit the block styles to list item also?
Theoretically, we could have more benefits than issues with it, so let's see.
#5271 has been marked as duplicate of this bug.