Ticket #3292 (closed Bug: expired)

Opened 4 years ago

Last modified 4 years ago

CKEDITOR.dom.range.getBoundaryNodes with collapsed range

Reported by: garry.yao Owned by:
Priority: Normal Milestone: CKEditor 3.1
Component: General Version:
Keywords: Cc:

Description

Currently the 'getBoundaryNodes' function is returning incorrect elements when range is collapsed, based on the semantic of the function, it should return 'null' for boundary nodes instead.

Attachments

range_boundaryNodes_collapsedRange.patch​ (1.8 KB) - added by garry.yao 4 years ago.
Unit Test Case

Change History

Changed 4 years ago by garry.yao

Unit Test Case

comment:1 Changed 4 years ago by garry.yao

A concrete example of failure caused by this bug would be when you asking 'CKEDITOR.dom.range.checkEndOfBlock' with the following, it will give a positive answer, which is wrong. 

<p>^text</p>

comment:2 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.0 to CKEditor 3.1

It looks like we don't need getBoundaryNodes anymore. The code using it should now use the dom walker to achieve in boundaries processing.

We need to check it later.

comment:3 Changed 4 years ago by garry.yao

  • Status changed from new to closed
  • Resolution set to expired

There's still few usage of CKEDITOR.dom.range::checkEndOfBlock in the codebase but we're about to deprecate it, so this ticket expired.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy