Opened 7 years ago

Closed 4 years ago

#3592 closed Bug (fixed)

"Title" attribute in flash dialog isn't useful

Reported by: alfonsoml Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.6.4
Component: UI : Dialogs Version: 3.0
Keywords: Cc:

Description

The <object> element might accept a "title" attribute, but the reality is that the browsers won't use it anyway with flash objects, so that's something that isn't useful to the end user and it would be better if it's removed.

Attachments (1)

3592.patch (1.4 KB) - added by alfonsoml 4 years ago.
Proposed patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by arczi

  • Milestone set to CKEditor 3.1

comment:2 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.1 to CKEditor 3.2

Apart from browsers support, we need to investigate the accessibility requirements related to it, if any.

comment:3 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.2 to CKEditor 3.3

comment:4 Changed 7 years ago by garry.yao

  • Keywords Pending added
  • Milestone changed from CKEditor 3.3 to CKEditor 3.x

comment:5 Changed 6 years ago by fredck

  • Milestone CKEditor 3.x deleted

Milestone CKEditor 3.x deleted

comment:6 follow-up: Changed 4 years ago by j.swiderski

  • Resolution set to invalid
  • Status changed from pending to closed
  • Version changed from SVN (CKEditor) - OLD to 3.0

Title attribute for object element is often displayed in browsers as tooltip but this is not the case in flash object. This attribute is also not read by JAWS 13.

Why not to remove this field:

  1. It is not deprecated even in HTML5.
  2. It doesn't do any damage.
  3. Despite that it is useless from our point of view we can't be sure that none of our users has built some tool that actually uses this attribute from flash object. Removing this filed would make him enter this value only in source mode and this is not very user friendly. This filed was present so long that we can't be sure that such scenario didn't take place.

I’m closing this issue but if anyone still thinks we should remove this filed please reopen it or leave a comment.

comment:7 in reply to: ↑ 6 Changed 4 years ago by fredck

  • Resolution invalid deleted
  • Status changed from closed to reopened

Replying to j.swiderski:

Unfortunately your point "3" is not a good justification to make this invalid.

Title attribute for object element is often displayed in browsers as tooltip but this is not the case in flash object. This attribute is also not read by JAWS 13.

This instead are very good reasons to make it valid.

The idea is that, if we can make things simpler, we should do it.

comment:8 Changed 4 years ago by fredck

  • Status changed from reopened to confirmed

Changed 4 years ago by alfonsoml

Proposed patch

comment:9 Changed 4 years ago by alfonsoml

  • Owner set to alfonsoml
  • Status changed from confirmed to review

comment:10 Changed 4 years ago by garry.yao

  • Component changed from General to UI : Dialogs
  • Milestone set to CKEditor 3.6.4
  • Status changed from review to review_passed

comment:11 Changed 4 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [7543].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy