Ticket #3633 (closed Bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Default context menu isn't disabled in toolbar, status bar, panels...

Reported by: alfonsoml Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

Load CKEditor and right click in the toolbar, status bar, any floating panel or context menu...

The default browser context menu is shown instead of showing nothing.

Attachments

3633.patch (2.1 KB) - added by tobiasz.cudnik 5 years ago.
3633_2.patch (2.0 KB) - added by tobiasz.cudnik 5 years ago.
3633_3.patch (724 bytes) - added by garry.yao 5 years ago.
3633_4.patch (2.5 KB) - added by tobiasz.cudnik 5 years ago.

Change History

comment:1 Changed 6 years ago by arczi

  • Keywords Confirmed added
  • Milestone set to CKEditor 3.1

comment:2 Changed 5 years ago by tobiasz.cudnik

  • Status changed from new to assigned
  • Owner set to tobiasz.cudnik

Changed 5 years ago by tobiasz.cudnik

comment:3 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review- added; Review? removed

Maybe it's better to add one single event preventer on the editor chrome instead?

Changed 5 years ago by tobiasz.cudnik

comment:5 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

I've merged preventers for toolbar and bottom part of chrome, but floatpanels have to have them separately.

comment:6 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:7 Changed 5 years ago by tobiasz.cudnik

Fixed with [4178].

comment:8 Changed 5 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:9 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review- added; Review+ removed
  • Status changed from closed to reopened
  • Resolution fixed deleted

[4178] (3633_2.patch) disables context menu in source area, which is an regression.

comment:10 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

I'm proposing including first patch 3633.patch because of reason mentioned above.

Changed 5 years ago by garry.yao

comment:11 Changed 5 years ago by garry.yao

Nice catch, but the advantages of prevent at the chrome level is that we can make sure every corner of the chrome is covered.

Changed 5 years ago by tobiasz.cudnik

comment:12 Changed 5 years ago by tobiasz.cudnik

I'm proposing a bit more flexible solution, although your's Garry one should work fine too.

Which one is more suitable for us ?

comment:13 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

R+ for 3633_4.patch

comment:14 Changed 5 years ago by tobiasz.cudnik

  • Status changed from reopened to closed
  • Resolution set to fixed

Post fixed with [4182] and [4183].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy