Ticket #3633 (closed Bug: fixed)
Default context menu isn't disabled in toolbar, status bar, panels...
| Reported by: | alfonsoml | Owned by: | tobiasz.cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | Confirmed Review+ | Cc: |
Description
Load CKEditor and right click in the toolbar, status bar, any floating panel or context menu...
The default browser context menu is shown instead of showing nothing.
Attachments
Change History
comment:2 Changed 4 years ago by tobiasz.cudnik
- Status changed from new to assigned
- Owner set to tobiasz.cudnik
comment:4 Changed 4 years ago by garry.yao
- Keywords Review- added; Review? removed
Maybe it's better to add one single event preventer on the editor chrome instead?
comment:5 Changed 4 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
I've merged preventers for toolbar and bottom part of chrome, but floatpanels have to have them separately.
comment:8 Changed 4 years ago by tobiasz.cudnik
- Status changed from assigned to closed
- Resolution set to fixed
comment:9 Changed 4 years ago by tobiasz.cudnik
- Keywords Review- added; Review+ removed
- Status changed from closed to reopened
- Resolution fixed deleted
[4178] (3633_2.patch) disables context menu in source area, which is an regression.
comment:10 Changed 4 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
I'm proposing including first patch 3633.patch because of reason mentioned above.
comment:11 Changed 4 years ago by garry.yao
Nice catch, but the advantages of prevent at the chrome level is that we can make sure every corner of the chrome is covered.
comment:12 Changed 4 years ago by tobiasz.cudnik
I'm proposing a bit more flexible solution, although your's Garry one should work fine too.
Which one is more suitable for us ?
comment:13 Changed 4 years ago by garry.yao
- Keywords Review+ added; Review? removed
R+ for 3633_4.patch
comment:14 Changed 4 years ago by tobiasz.cudnik
- Status changed from reopened to closed
- Resolution set to fixed
