Ticket #3727 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Cell Properties dialog missing color selection option

Reported by: damo Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.1
Component: General Version:
Keywords: IBM Confirmed Review+ Cc:

Description

The cell border & background color options in the Cell Properties dialog do not provide an easy way for users to select colors.

FCKEditor 2.6 provides a color selector in this case.

Attachments

3727.patch (70.7 KB) - added by tobiasz.cudnik 5 years ago.
3727_2.patch (70.7 KB) - added by tobiasz.cudnik 5 years ago.

Change History

comment:1 Changed 5 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from new to assigned
  • Keywords Confirmed added

comment:2 Changed 5 years ago by fredck

  • Milestone changed from CKEditor 3.0 to CKEditor 3.1

We're not able to have this feature for the 3.0.

Changed 5 years ago by tobiasz.cudnik

comment:3 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added

Patch reproduces color picker for table cells from FCKeditor. Most of old dialog's code had been reused.

Everything seems to work fine, but i have some doubts regarding cell property dialog layout. Right now it mimics V2 one, but it has some issues (check IE quirks) caused by new buttons. I'm proposing relocating them below text field.

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review- added; Review? removed

The patch is almost good for me, except:

  1. The color dialog matrix doesn't work in safari.
  2. Coding styles should be changed when migrating codes from v2.

comment:5 Changed 5 years ago by garry.yao

While it's always safe and prior to align with v2 features, I would vote for using float panel for this feature as Tobias mentioned, we could consider it after this got fixed.

Changed 5 years ago by tobiasz.cudnik

comment:6 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

Next patch fixes Safari 3 issue, which seems to have limit for table markup (?!), because it works with 3/4 of color table, but not with the whole one.

That's why i've delegated mouseover and click event handlers to table root, which reduced the markup and allowed safari3 to work.

I don't have this issue on safari4 (4.0 530.17 win).

comment:7 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

The 'borderColor' attribute doesn't work for none-IE, please open a dedicated ticket for it as soon as this get closed.

comment:8 Changed 5 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [4185].

borderColor issue is available as #4368.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy