Automatic color options don't seem to do anything

[damo]

The Font color and Background color toolbar options provide an "Automatic" selection. Based on the way that FCKEditor 2.6 has implemented this option, it should reset the background/font color. This doesn't appear to work in the nightly CKEditor builds.

[martinkou]

This is due to some missing logic in colorbutton plugin.

[garry.yao]

I think you fixing is somehow conflicting with the existing logic there:

					if ( color )
						style.apply( editor.document );
					else
						style.remove( editor.document );

So the correct fix would either remove the current colored style OR apply the inherited style.

[martinkou]

There's no conflict there. If the color is to be removed, then color would be null and thus style.remove() is executed. What's missing is that we need to detect the color to be removed before running style.remove(), and that's what my patch does.

[garry.yao]

Sorry, my fault, doesn't get the idea of your patch.

[fredck]

The proposed patch doesn't work on mixed colors selection.

[fredck]

It looks like it was just a small misunderstanding in the original implementation. I've a new patch for it.

[fredck]

Fixed with [3688].