Ticket #3804 (closed Bug: fixed)
[IE] context menu position wrong for long document
| Reported by: | garry.yao | Owned by: | martinkou |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Context Menu | Version: | |
| Keywords: | 3.0RC IE Review+ | Cc: |
Description (last modified by garry.yao) (diff)
Reproducing Procedures
- Open the attached sample page in IE;
- Scroll the viewport to document end;
- Right click to show up context menu;
- Expected Result: Context menu show up at the position where mouse click happened.
- Actual Result: Context menu is not align correctly in view port.
Attachments
Change History
Changed 4 years ago by garry.yao
- Attachment sample_for_reproduce.html added
Sample page for reproducing
comment:2 Changed 4 years ago by garry.yao
- Keywords 3.0RC Review? added
- Owner set to garry.yao
- Status changed from new to assigned
Not sure about the patch, but found L1106 of element.js is causing IE offset to be wrong:
editorFrame.getBoundingClientRect() // Always returning top as -1
comment:3 Changed 4 years ago by martinkou
- Keywords Review- added; Review? removed
Forcing the scroll check for IE should be wrong.
We're looking for the coordinates of the <html> element in our case, and therefore adding the scrollLeft and scrollTop to it is senseless - the html element is supposed to be the thing containing the scrollbar, not the other way round.
However, if you consider the common case where we're looking for the position of something inside that <html> element, then the scroll check would make sense.
Also, since different iframes can be rendered in standards/quirks mode separately, relying on CKEDITOR.env.quirks is also wrong.
comment:4 Changed 4 years ago by martinkou
- Owner changed from garry.yao to martinkou
- Status changed from assigned to new
comment:6 Changed 4 years ago by martinkou
- Keywords Review? removed
:(
Now the context menu is broken in non-IE browsers. Retracting the review request.
comment:8 Changed 4 years ago by martinkou
- Status changed from new to assigned
Updated patch with comments explaining the purpose of the needAdjustScrollAndBorders flag.
comment:10 Changed 4 years ago by martinkou
- Status changed from assigned to closed
- Resolution set to fixed
Fixed with [3742].
Click here for more info about our SVN system.
