Opened 8 years ago
Closed 8 years ago
#3834 closed Bug (fixed)
Context menu on table caption incorrect
| Reported by: | garry.yao | Owned by: | tobiasz.cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Context Menu | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the replace by class example page;
- Make the following content with selection;
<table> <caption> cap^tion</caption> <tbody> <tr> <td>cell</td> </tr> </tbody> </table>
- Right click to open context menu,
- Exptected Result: 'Cell' menu item should be disabled.
- Actual Result: It's possible to select 'Cell' to open sub menu.
Attachments (2)
Change History (8)
comment:1 Changed 8 years ago by tobiasz.cudnik
- Owner set to tobiasz.cudnik
- Status changed from new to assigned
comment:2 Changed 8 years ago by tobiasz.cudnik
- Keywords Confirmed Review? added
Changed 8 years ago by tobiasz.cudnik
comment:3 Changed 8 years ago by fredck
- Keywords Review- added; Review? removed
- There is no need to create the "tagName" variable. It's used only once, so you can use element.getName() directly. You may do contextMenuTags[ element.getName() ].
- The same thing for showContextMenu, we don't need a variable here. The condition can go straight into the if.
- The contextMenuTags definition can be moved out, into the main anonymous function scope, so it's created only once.
- There is an unwanted change in the changelog file at line 1.
Changed 8 years ago by tobiasz.cudnik
comment:4 Changed 8 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
I've applies all your suggestions in second patch.
comment:5 Changed 8 years ago by garry.yao
- Keywords Review+ added; Review? removed
Please comment out the related ticket number inline before submit.
comment:6 Changed 8 years ago by tobiasz.cudnik
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with [3792].
Note: See
TracTickets for help on using
tickets.
