Create list command leaking into the rest of the document.

[martinkou]

The symptom of this bug seems similar to #3780, but so far I've found it to be caused by the domiterator and thus it is a actually very different beast.

To reproduce:

1. Open replacebyclass.html in Firefox.
2. Create a default table.
3. Press Shift-Enter in any of the table cells.
4. Press up to move the caret back to the beginning of the table cell.
5. You'll see the list command has leaked into all table cells that comes after the currently selected one, and then also to the rest of the document.

This bug was discovered while working on #3782.

[martinkou]

This bug seems to be a regression from [3609].

[garry.yao]

The patch works, but for safety, I would suggest to not only limit to empty text node but any empty spaces:

this._.lastNode.type == CKEDITOR.NODE_TEXT && this._.lastNode.getLength() == 0

Even further, how do you think of this more generic:
source:CKEditor/trunk/_source/plugins/domiterator/plugin.js#L53​- L61

var walker = new CKEDITOR.dom.walker( range ),
bookmarkTextGuard = CKEDITOR.dom.walker.bookmark( true, true ),
// Reject any empty spaces.
emptySpacesGuard = CKEDITOR.dom.walker.emptySpaces( true ),
ignoreBookmarkTextEvaluator = function( node )
{
return bookmarkTextGuard( node ) || emptySpacesGuard( node ) 
};

[martinkou]

The evaluator approach doesn't work because the walker never touched the empty text node anyway.

[garry.yao]

Can you please use:

!CKEDITOR.tool.trim( this._.lastNode.getText() )

Instead of

/^[ \t\r\n]*$/.test( this._.lastNode.getText( )

[martinkou]

Fixed with [3850].

Click here for more info about our SVN system.