Opened 8 years ago
Closed 8 years ago
#3951 closed Bug (fixed)
Reset size and lock ratio options not accessible in Image dialog
| Reported by: | damo | Owned by: | tobiasz.cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | |
| Keywords: | IBM Confirmed Review+ | Cc: |
Description
The two options "reset size" and "lock ratio" are not keyboard accessible.
Attachments (3)
Change History (10)
comment:1 Changed 8 years ago by tobiasz.cudnik
- Component changed from General to UI : Dialogs
- Keywords Confirmed added
- Owner set to tobiasz.cudnik
- Status changed from new to assigned
Changed 8 years ago by tobiasz.cudnik
comment:2 Changed 8 years ago by tobiasz.cudnik
- Keywords Review? added
Changed 8 years ago by tobiasz.cudnik
comment:3 Changed 8 years ago by tobiasz.cudnik
Corrected one unsatisfied reference, some coding style and added changelog entry.
comment:4 Changed 8 years ago by garry.yao
- Keywords Review- added; Review? removed
As discussed with Tobiasz, the inner closure 'addFocusable' should be extracted.
Changed 8 years ago by tobiasz.cudnik
comment:5 Changed 8 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
I've relocated Focusable declaration and removed module pattern. Also dialog reference is now passed as constructor parameter.
comment:6 Changed 8 years ago by fredck
- Keywords Review+ added; Review? removed
This is a very good solution.
comment:7 Changed 8 years ago by tobiasz.cudnik
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with [3911].
Note: See
TracTickets for help on using
tickets.
I'm introducing new dialog's method addFocusable, which allows any element to be easily added to dialog's focus list. Keyboard events are transparently converted to mouse equivalents.
Element have to be browser-focusable to this to work.