Opened 7 years ago

Closed 7 years ago

#3951 closed Bug (fixed)

Reset size and lock ratio options not accessible in Image dialog

Reported by: damo Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version:
Keywords: IBM Confirmed Review+ Cc:

Description

The two options "reset size" and "lock ratio" are not keyboard accessible.

Attachments (3)

3951.patch (4.1 KB) - added by tobiasz.cudnik 7 years ago.
3951_2.patch (4.8 KB) - added by tobiasz.cudnik 7 years ago.
3951_3.patch (4.8 KB) - added by tobiasz.cudnik 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by tobiasz.cudnik

  • Component changed from General to UI : Dialogs
  • Keywords Confirmed added
  • Owner set to tobiasz.cudnik
  • Status changed from new to assigned

Changed 7 years ago by tobiasz.cudnik

comment:2 Changed 7 years ago by tobiasz.cudnik

  • Keywords Review? added

I'm introducing new dialog's method addFocusable, which allows any element to be easily added to dialog's focus list. Keyboard events are transparently converted to mouse equivalents.

Element have to be browser-focusable to this to work.

Changed 7 years ago by tobiasz.cudnik

comment:3 Changed 7 years ago by tobiasz.cudnik

Corrected one unsatisfied reference, some coding style and added changelog entry.

comment:4 Changed 7 years ago by garry.yao

  • Keywords Review- added; Review? removed

As discussed with Tobiasz, the inner closure 'addFocusable' should be extracted.

Changed 7 years ago by tobiasz.cudnik

comment:5 Changed 7 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

I've relocated Focusable declaration and removed module pattern. Also dialog reference is now passed as constructor parameter.

comment:6 Changed 7 years ago by fredck

  • Keywords Review+ added; Review? removed

This is a very good solution.

comment:7 Changed 7 years ago by tobiasz.cudnik

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [3911].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy