Ticket #3950 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[Safari] Insert column before/after problematic

Reported by: damo Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed WebKit Review+ Cc:

Description (last modified by fredck) (diff)

To reproduce:

  1. Open nightly sample
  2. Insert table with 3 columns
  3. Populate the cells in the first row to keep track of them.
  4. Select and right click in the empty area of a cell in the first row (to the right of the text in the cell)
  5. Attempt to insert a column before the current column

Result is that the column is added to the beginning of the table and not before the selected column

Attachments

3950.patch (1.5 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Keywords WorksForMe added

WFM,Could you tell me on which cell did you trigger the menu exactly?

comment:2 follow-up: ↓ 3 Changed 5 years ago by damo

I tried on the last cell in the first row, and on a middle cell in the first row.

The important thing is to right click in the empty part of the cell.

I am using Safari 3.2.2 on WinXP.

comment:3 in reply to: ↑ 2 Changed 5 years ago by fredck

  • Keywords Confirmed WebKit added; WorksForMe removed
  • Version set to SVN (CKEditor)

Replying to damo:

I am using Safari 3.2.2 on WinXP.

That's all we needed to know. Please always include the browser version in the reports.

I've confirmed it on Safari. Ok with FF and IE.

comment:4 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned

Changed 5 years ago by garry.yao

comment:5 Changed 5 years ago by garry.yao

  • Keywords Review? added

It could be considered as a regression of [3456], where determinate the selectedElement for selection below:

<tr><td>cell1[</td><td>]cell2</td></tr>

The cell2 <td> is reported instead of the first one, I'm proposing of limit #3231's fix to only inline elements to avoid this problem temporarily.

The real criminal is the context menu on safari( chrome doesn't have the problem), on 'contextmenu' event, instead of keeping the current document selection, the browser is trying to grabbing a word range in place, which is really cumbersome and troublesome. Even worse, this behavior is very hard to prevent, I've tried various way without reaching an idea result, we can have it under investigation later.

comment:6 Changed 5 years ago by fredck

  • Description modified (diff)

comment:7 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:8 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [4516]. Ticket Manual Test added at :
http://ckeditor.t/tt/3950/1.html.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy