Opened 8 years ago
Closed 8 years ago
#4003 closed Bug (fixed)
Markup on the image dialog disrupted when removing the border input
| Reported by: | Saare | Owned by: | tobiasz.cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | |
| Keywords: | IE Confirmed Review+ | Cc: |
Description
When removing the border option, the whole dialog markup is disrupted (on IE).
It only happens if the language uses RTL direction.
Attachments (2)
Change History (14)
comment:1 Changed 8 years ago by fredck
comment:2 Changed 8 years ago by fredck
Also... do you have this issue with the Kama skin?
comment:3 Changed 8 years ago by Saare
Right now i'm using IE8 but it also happend on IE7. And no, i'm not having this issue with the Kama skin.
comment:5 Changed 8 years ago by tobiasz.cudnik
- Owner set to tobiasz.cudnik
- Status changed from new to assigned
comment:6 Changed 8 years ago by tobiasz.cudnik
- Keywords IE Pending added
Sorry, but can't reproduce it.
I've checked office2003 skin in quirks and strict mode using Arabic language. I've set border value, it got applied on preview, then removed it and nothing has changed in dialog layout.
comment:7 Changed 8 years ago by fredck
- Keywords Confirmed added; Pending removed
It looks like it happens if the connection is not that fast, so the dialog takes time to load and build.
I'm able to reproduce it with a clean cache, when loading the ckeditor.js file from the nightly build.
comment:8 Changed 8 years ago by fredck
I'm able to reproduce it with the file I've just attached to this ticket. It happens always with a clean cache and IE7.
Changed 8 years ago by tobiasz.cudnik
comment:9 Changed 8 years ago by tobiasz.cudnik
This patch double checks dialog size to ensure that borders are correct.
We can extract references to elements outside function to avoid double creations.
comment:10 Changed 8 years ago by tobiasz.cudnik
- Keywords Review? added
comment:11 Changed 8 years ago by fredck
- Keywords Review+ added; Review? removed
Ok... that's ugly though... anyway, let's do this way and then wait for the feedback.
comment:12 Changed 8 years ago by tobiasz.cudnik
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with [3983].
Which IE version precisely?