Maximize control's tool tip is wrong once it is maximized

[Senthil]

Once the editor is maximized using the maximize control, the maximize control's tooltip should show as 'Minimize' instead of that it still shows as 'Maximize'

[Garry Yao]

Instead of augment toolbox::getItem, I think it's better if we could introduce a method for commands which retrieve the associate ui button if exist as CKEDITOR.command::getUIButton, any button related manipulation could happen based on it:

var cmdButton = this.getUIButton();

[Tobiasz Cudnik]

Second patch introduces CKEDITOR.command::getButtons() method, which will return all buttons related to a command.

In a way i see this is that we should keep toolbox::getItem method as it's more related to a toolbar. Besides that we should provide some more relation between toolbar markup, toolbar object and toolbar definition, which are right now not linked in any way. Also possibility of re-rendering parts of the toolbar, while still keeping existing references can be considered as useful.

[Frederico Caldeira Knabben]

This patch creates a dependency between the core code and the plugins. The _source/core/command.js file should not be touched for it, but it should be managed at the toolbar plugin (which could extend the command class).

Another point is that the toolbar doesn't hold buttons only. It can have any kind of UI element. So, the function could be named more generically, and considering that it's limited to the toolbar elements it could be named getToolbarItems.

[Tobiasz Cudnik]

With some help from Garry i'm proposing simplified patch with no additional method and command->ui references.

[Garry Yao]

Please remove the unused prototype fields 'editor' and 'uiItems' there before commit it.

[Tobiasz Cudnik]

Fixed with [4137].

[Tobiasz Cudnik]

IE6 have issues with used guard statement. I'm attaching quick fix for it.

[Tobiasz Cudnik]

Post fixed with [4139].