Ticket #4041 (closed Bug: fixed)
[IE] Remove multiple rows doesn't work
| Reported by: | garry.yao | Owned by: | garry.yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | Core : Styles | Version: | |
| Keywords: | IE Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the 'replace by class' sample page.
- Load the document with following content and selection:
<table> <tbody> <tr> <td> [row1</td> </tr> <tr> <td> row2]</td> </tr> </tbody> </table>
- Open context menu and 'row' submenu, click 'Delete Rows'.
- Actual Result: Only row2 get deleted.
Attachments
Change History
comment:2 Changed 4 years ago by garry.yao
- Owner set to garry.yao
- Status changed from new to assigned
comment:5 Changed 4 years ago by fredck
- Keywords Review- added; Review? removed
I'm having an undesired effect after the patch. The prooblem is that the selection is "always" restored in the editor, even if I'm clicking out of it to close the context menu. TC:
- Open the editor in a page that can be scrolled.
- Select some text and open the context menu for it.
- Scroll down the page with the mousewhel, so the context menu will not get closed. Do that until the editor is not anymore visible.
- Click at the page... it will scroll up to show the restored selection.
comment:6 Changed 4 years ago by garry.yao
- Keywords Review? added; Review- removed
Find an alternative solution for it without any draw backs.
comment:8 Changed 4 years ago by fredck
- Keywords Review- added; Review? removed
The proposed patch will not work withe the following selection case:
<table> <tbody> <tr> <td> <strong>r[ow1</strong></td> </tr> <tr> <td> <strong>row]2</strong></td> </tr> </tbody> </table>
comment:10 follow-up: ↓ 12 Changed 4 years ago by garry.yao
- Keywords Review? added; Review- removed
Note that it's even not an ultimate solution, actually the issue is not limited to only 'table element', instead all elements that been displayed as control type is effected including but not limited to the following:
- Floated block. See #3670
- Sized block. e.g. <p style="width:300px">paragraph</p>
After closed this ticket, we should investigate on the proper way to enumerate/determinate this kind of elements for handling them in a similar manner with this case.
comment:11 Changed 4 years ago by garry.yao
Manual TCs added at : http://ckeditor.t/tt/4041/1.html
comment:12 in reply to: ↑ 10 Changed 4 years ago by garry.yao
comment:13 Changed 4 years ago by fredck
- Keywords Review- added; Review? removed
The patch is got... there is a minor improvement we could have on it. The "target" variable is not anymore needed. In fact, by moving evt.data.getTarget() inside the if check, we avoid executing it if the button is different of "2".
The R+ will come immediately after this small change.
comment:16 Changed 4 years ago by garry.yao
Fixed with [4521].
comment:17 Changed 4 years ago by garry.yao
- Status changed from assigned to closed
- Resolution set to fixed
