Context submenu lacks uiColor

[Tobiasz Cudnik]

Context submenu lacks uiColor in Kama skin.

[Frederico Caldeira Knabben]

These changes are a bit risky at this point. Let's delay it a bit.

In any case, i think we should find a solution where the other plugins can listen for the uiColor changes somehow, adapting themselves to the changes. In this way the menu plugin would have menu specific code for it, instead of having it in the skin files.

[Artur Formella]

It is possible to change context menu UI color only once.

[Tobiasz Cudnik]

@Frederico: It's not fully possible to move menu-related code to menu plugin, because CSS is skin-dependent, so it will have to stay inside skin files. Although keeping references inside menu objects and listening for an uiColorChanged event may be a good solution.

@Artur: It's a know issue (there is a ticket somewhere i think). That's because missing reference to style element at some point. It needs deeper investigation.

[Tobiasz Cudnik]

Second patch changes relation with menu plugin to be event based, which resolves both submenu and sequential uiColor changes issues (mentioned by Artur). Also code is now more general purpose and can manage ui color more easily in any iframe document.

[Garry Yao]

The patch works for me in all browsers, while there're some issues noticed in codes:

1. L160 - L170 of skin.js could be merged into 'updateStylesheets' function;
2. It's better to use RegExp for global replacement;
3. L176 - L192 should be merged within the guard condition at L195.

[Tobiasz Cudnik]

Replying to garry.yao:

The patch works for me in all browsers, while there're some issues noticed in codes:

1. L160 - L170 of skin.js could be merged into 'updateStylesheets' function;
   
2. It's better to use RegExp for global replacement;
   
3. L176 - L192 should be merged within the guard condition at L195.
   

1 and 2 are fixed.

Although 3 is incorrect, because UI color functionality should be available independently from having a uiColor setting in a config. It can be set using editor.setUiColor() in any moment and we shouldn't block it.

[Tobiasz Cudnik]

Fixed with [4180].