Opened 7 years ago

Closed 7 years ago

#4082 closed Bug (fixed)

[IE+Quirks] Preview text in the image dialog is not wrapping

Reported by: fredck Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed IE Review+ Cc:

Description

The preview text displayed in the Image dialog is not wrapping with IE7+Quirks.

Attachments (5)

4082.patch (1.4 KB) - added by m.nguyen 7 years ago.
4082_2.patch (1.9 KB) - added by m.nguyen 7 years ago.
4082_3.patch (2.0 KB) - added by m.nguyen 7 years ago.
4082_ref.patch (2.1 KB) - added by garry.yao 7 years ago.
4082_5.patch (3.9 KB) - added by m.nguyen 7 years ago.
New approach

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by m.nguyen

comment:1 Changed 7 years ago by m.nguyen

  • Keywords Review? added
  • Milestone changed from CKEditor 3.x to CKEditor 3.3
  • Owner set to m.nguyen
  • Status changed from new to assigned

comment:2 Changed 7 years ago by m.nguyen

IE very interesting. I cannot explain why use '*' instead of '#ImagePreviewBox' in this case.

comment:3 Changed 7 years ago by garry.yao

  • Keywords Review- added; Review? removed

It works while make some of the dialog fields label wrapping incorrectly.
We should narrow down the selector if possible.

Changed 7 years ago by m.nguyen

comment:4 Changed 7 years ago by m.nguyen

  • Keywords Review? added; Review- removed

Changed 7 years ago by m.nguyen

comment:5 Changed 7 years ago by m.nguyen

  • Keywords Review- added; Review? removed

comment:6 Changed 7 years ago by m.nguyen

  • Keywords Review? added; Review- removed

comment:7 Changed 7 years ago by garry.yao

  • Keywords Review- added; Review? removed

The latest patch is heading the correct way, while reset.css should only perform browser normalization instead of holding rules of a specific structure.
Providing a patch for reference.

Changed 7 years ago by garry.yao

Changed 7 years ago by m.nguyen

New approach

comment:8 Changed 7 years ago by m.nguyen

  • Keywords Review? added; Review- removed

comment:9 Changed 7 years ago by garry.yao

  • Keywords Review+ added; Review? removed

It's a nice solution, table is highly welcomed by browsers in quirks :)

comment:10 Changed 7 years ago by m.nguyen

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5317].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy