Opened 8 years ago
Closed 8 years ago
#4117 closed Bug (fixed)
[IE] Transform image into imagebutton problem
| Reported by: | garry.yao | Owned by: | garry.yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | |
| Keywords: | IE Confirmed Review+ | Cc: |
Description
Reproducing Procedures
- Open the 'replace by class' sample page in IE;
- Load the document will following cotent and selection:
[<img alt="title" height="43" src="http://dev.fckeditor.net/chrome/site/logos.gif" width="207" />]
- Open 'Image Button' dialog and click 'OK';
- Actual Result: JavaScript error thrown.
Attachments (5)
Change History (17)
Changed 8 years ago by garry.yao
comment:1 Changed 8 years ago by garry.yao
- Keywords Review? added
- Status changed from new to assigned
comment:2 Changed 8 years ago by fredck
- Keywords Review- added; Review? removed
The changes lookg good. There is just a "debugger" line that has been left at line 311.
Changed 8 years ago by garry.yao
comment:3 Changed 8 years ago by garry.yao
- Keywords Review? added; Review- removed
Beside the fix, another small change regard L288 of 4117.patch which should be routed into respected conditional block.
comment:4 Changed 8 years ago by fredck
This ticket depends on #4119, which needs to be fixed first.
comment:5 Changed 8 years ago by fredck
- Keywords Review- added; Review? removed
The attempt to remove the link (by emptying the field) is not anymore working after the proposed patch.
Changed 8 years ago by garry.yao
comment:6 Changed 8 years ago by garry.yao
- Keywords Review? added; Review- removed
comment:7 Changed 8 years ago by fredck
- Keywords Review- added; Review? removed
With IE only, I'm having an error in the attempt to remove the link by cleaning the link URL field.
Changed 8 years ago by garry.yao
comment:8 Changed 8 years ago by garry.yao
- Keywords Review? added; Review- removed
This lead us to a mistake within selection plugin, fixing it with other parts untouched.
comment:9 Changed 8 years ago by fredck
- Keywords Review- added; Review? removed
A console.log call has been left at line 343.
Changed 8 years ago by garry.yao
comment:11 Changed 8 years ago by fredck
- Keywords Review+ added; Review? removed
comment:12 Changed 8 years ago by garry.yao
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with [3999].
Note: See
TracTickets for help on using
tickets.

All the modification to document elements in dialog must obey the editor::insertElement rule in order to not break the selection in IE.