Ticket #4195 (review_failed Bug)

Opened 3 years ago

Last modified 9 months ago

Inline quotion style problematic

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone:
Component: Core : Styles Version: SVN (CKEditor) - OLD
Keywords: Confirmed Cc:

Description

Sometimes inline style should own priority, style with higher priority should be applied at a more high level. Here's a concrete example

Reproducing Procedures

  1. Open the 'replace by class' sample page;
  2. Load the following content with selection:
    <p>
    	<strong>[some</strong>test<strong>text]</strong></p>
    
  3. Apple 'Line Quatation" from 'Format' combo;
    • Actual Result:
      <p>
      	<strong>so<q>me</q></strong><q>test</q><strong><q>te</q>xt</strong></p>
      
    • Expected Result: The quatatoin style doesn't break into pieces
      <p>
      	<strong>so</strong><q><strong>me</strong>test<strong>te</strong></q><strong>xt</strong></p>
      

Attachments

4195.patch Download (2.5 KB) - added by garry.yao 23 months ago.

Change History

comment:1 Changed 2 years ago by garry.yao

  • Version set to SVN (CKEditor)
  • Milestone changed from CKEditor 3.1 to CKEditor 3.2

comment:2 Changed 2 years ago by fredck

  • Milestone changed from CKEditor 3.2 to CKEditor 3.3

comment:3 Changed 2 years ago by garry.yao

  • Keywords Confirmed added
  • Owner set to garry.yao
  • Status changed from new to assigned

Similar with #3599.

Changed 23 months ago by garry.yao

comment:4 Changed 23 months ago by garry.yao

  • Keywords Review? added

comment:5 Changed 23 months ago by fredck

  • Milestone changed from CKEditor 3.3 to CKEditor 3.x

The "intact" name doesn't look like intuitive for this property in the style definition. We must think about something better.

comment:6 Changed 19 months ago by fredck

  • Milestone CKEditor 3.x deleted

Milestone CKEditor 3.x deleted

comment:7 Changed 9 months ago by fredck

  • Status changed from review to review_failed

This patch needs to be updated. Additionally, instead of "intact", let's call the property "maximize" or "avoidBreak", or anything that makes it more meaningful.

Note: See TracTickets for help on using tickets.
© 2003 – 2011 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy