Ticket #4231 (closed New Feature: fixed)
Vertical only resize
| Reported by: | mike890 | Owned by: | alfonsoml |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | General | Version: | 3.0 |
| Keywords: | Confirmed Review+ | Cc: |
Description
In many cases it is necessary to have vertical only resize with 100% width of the editor. The current resize addin does not support this configuration.
See more about this feature @ http://www.fckeditor.net/forums/viewtopic.php?f=11&t=15334
Attachments
Change History
comment:2 Changed 4 years ago by brandonkelly
I suggest making this setting accept two values: 'x' and 'y' rather than just a restrict-to-vertical flag. Maybe call it 'resize_restrictToAxis' or something.
comment:3 Changed 4 years ago by garry.yao
- Version set to SVN (CKEditor)
- Milestone changed from CKEditor 3.1 to CKEditor 3.2
comment:5 Changed 3 years ago by alfonsoml
- Keywords Review? added
- Owner set to alfonsoml
- Version changed from SVN (CKEditor) to 3.0
- Status changed from new to assigned
The patch checks if the min and width have the same value and in that case ignores the changes of the resizer for that dimension.
comment:6 Changed 3 years ago by garry.yao
- Keywords Review- added; Review? removed
I don't think this's the best way for such feature, will two extra one-dimension resize handler be a better choice?
comment:7 Changed 3 years ago by garry.yao
At least we should have separate config entries for them.
comment:8 Changed 3 years ago by alfonsoml
- Keywords Review? added; Review- removed
I see that I wrote the description wrong.
The patch checks if min and max values for a dimension have the same values, that means that the user doesn't want that dimension bigger or smaller that such value, and in that case that dimension isn't resized.
So without any extra config entries it's possible to disable the vertical or horizontal resize.
comment:9 Changed 3 years ago by fredck
- Keywords Review- added; Review? removed
We need a dedicated setting for it. The fact is that, by default, users don't know what are the min and max values... in fact they don't care about the width at all, having the default values as good. They just want to have the editor resizable vertically only. We also have percent widths just to make things more complex.
Let's make it simpler for us and for our users: config.resize_dir = "both|vertical". We could have it also "horizontal" if it's easy to have, but that's not a priority.
comment:10 Changed 3 years ago by alfonsoml
- Keywords Review? added; Review- removed
The new patch introduces such config setting, as well as the previous system of automatically disabling resizing if max==min
comment:11 Changed 3 years ago by garry.yao
- Keywords Review- added; Review? removed
Almost there, we need a skin change to indicate the direction with different cursor type (s-resize and e-resize) also.
comment:12 Changed 3 years ago by alfonsoml
- Keywords Review? added; Review- removed
Cursor adjusted in new patch.
I've filed #5644 to provide new pictures for the grabber and place it in the middle of the bottom bar (or right side) for vertical or horizontal only resize.
comment:14 Changed 3 years ago by alfonsoml
- Status changed from assigned to closed
- Resolution set to fixed
Fixed with [5478]
