Ticket #4272 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[IE] Kama skin toolbar broken in RTL+quirks

Reported by: tobiasz.cudnik Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.2
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Kama IE Review+ Cc:

Description (last modified by tobiasz.cudnik) (diff)

Kama skin toolbar broken in RTL+quirks. Refer to attached screenshot. Reproduced in IE8.

Attachments

2009-08-21-133252_799x527_scrot.png (30.3 KB) - added by tobiasz.cudnik 5 years ago.
config.js (824 bytes) - added by tobiasz.cudnik 5 years ago.
4272.patch (1.1 KB) - added by tobiasz.cudnik 5 years ago.
4272_2.patch (1.3 KB) - added by m.nguyen 5 years ago.
4272_3.patch (1.5 KB) - added by m.nguyen 5 years ago.

Change History

Changed 5 years ago by tobiasz.cudnik

comment:1 Changed 5 years ago by tobiasz.cudnik

  • Keywords IE added
  • Description modified (diff)
  • Summary changed from Kama skin toolbar broken in RTL+quirks to [IE] Kama skin toolbar broken in RTL+quirks

Changed 5 years ago by tobiasz.cudnik

comment:2 Changed 5 years ago by tobiasz.cudnik

  • Status changed from new to assigned
  • Owner set to tobiasz.cudnik

Changed 5 years ago by tobiasz.cudnik

comment:3 Changed 5 years ago by tobiasz.cudnik

Fix limited to IE quirks only. Tested on IE 6, 7, 8 and seems to work.

comment:4 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added

comment:5 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

This fix breaks the combo contents positioning. Confirmed in IE8 in LTR after patch.

comment:6 Changed 5 years ago by fredck

  • Milestone changed from CKEditor 3.1 to CKEditor 3.2

comment:7 Changed 5 years ago by tobiasz.cudnik

  • Status changed from assigned to new
  • Owner tobiasz.cudnik deleted

comment:8 Changed 5 years ago by m.nguyen

RTL feature doesn't work in almost browser with version trunk.

Changed 5 years ago by m.nguyen

comment:9 Changed 5 years ago by m.nguyen

  • Status changed from new to assigned
  • Keywords Review? added; Review- removed
  • Owner set to m.nguyen

comment:10 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed
  • As the name says, "contentsLangDirection" is related to the direction of the contents, not the UI. The UI instead is editor.lang.dir.
  • In any case, CSS for the UI must not go inline in the code, but in the skin CSS files. CSS selectors should be used to apply RTL specific style (.cke_rtl).

comment:11 Changed 5 years ago by m.nguyen

  • Keywords Review? added; Review- removed

comment:12 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

Changed 5 years ago by m.nguyen

comment:13 Changed 5 years ago by m.nguyen

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5110].

comment:14 Changed 5 years ago by m.nguyen

and [5112].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy