Ticket #4273 (closed Bug: expired)

Opened 2 years ago

Last modified 13 months ago

TD > UL > SPAN Causes FCKTableHandler.GetSelectedCells() to return nothing on right click

Reported by: dshafik Owned by:
Priority: Normal Milestone:
Component: General Version: FCKeditor 2.4.3
Keywords: HasPatch Cc:

Description

This is an involved issue, so bear with me:

1) Create a table 2) Insert a List (UL or OL should trigger the issue) 3) Add some text to the list item, and style is using the Style drop down

You end up with something like:

<table>
    <tr>
       <td>
          <ul>
             <li><span style="color: red">Text</span></li>
          </ul>
       </td>
    </tr>
</table>

Then, right click on the span, and go to Cell > Cell Properties and try to set Horizontal Alignment to Right and click OK.

You end up with nothing being changed.

The reason is, FCKTableHandler.GetSelectedCells() at source:/FCKeditor/tags/2.6.4/editor/dialog/fck_tablecell.html#L38 returns no cells.

Attached is a patch to correct the issue.

Attachments

fcktablehandler_gecko.js-select-bug.patch Download (706 bytes) - added by dshafik 2 years ago.
fcktablehandler_gecko.js-select-bug-2.patch Download (740 bytes) - added by dshafik 2 years ago.
Added missing semi-colon that breaks FCK when compressed

Change History

Changed 2 years ago by dshafik

comment:1 Changed 2 years ago by dshafik

I have an updated patch that works in more situations as sometimes the LI is passed in, sometimes the UL, or OL

Changed 2 years ago by dshafik

Added missing semi-colon that breaks FCK when compressed

comment:2 Changed 2 years ago by fredck

  • Keywords HasPatch WorksForMe added; **Firefox** removed
  • Milestone FCKeditor 2.6.5 deleted

It works for me with FF 3.5. I have the impression that something is missing in the reproduction steps. Is it necessary to right click in any specific place to see the bug?

comment:3 Changed 13 months ago by wwalc

  • Status changed from pending to closed
  • Resolution set to expired

Please reopen this issue if this bug can be still reproduced in CKEditor 3.x.

Works for me:

<table>
	<tbody>
		<tr>
			<td style="text-align: right;">
				<ul>
					<li>
						<span style="color: red;">Text</span></li>
				</ul>
			</td>
		</tr>
	</tbody>
</table>
Note: See TracTickets for help on using tickets.
© 2003 – 2011 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy