Opened 7 years ago

Closed 7 years ago

#4512 closed Bug (fixed)

TC from dt/plugins/styles is broken because of semicolon fixing

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Styles Version: SVN (CKEditor) - OLD
Keywords: Safari Confirmed Review+ Cc:

Description

Extra semicolons get introduced due to the following codes: 

for ( var style in stylesDef )
 stylesText += style + ':' + stylesDef[ style ] + ';';

Attachments (2)

4512.patch​ (1.2 KB) - added by garry.yao 7 years ago.
4512_2.patch​ (629 bytes) - added by garry.yao 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by garry.yao

comment:1 Changed 7 years ago by garry.yao

  • Keywords Review? added
  • Owner set to garry.yao
  • Status changed from new to assigned

comment:2 Changed 7 years ago by fredck

  • Keywords Review- added; Review? removed

I know it's a small repetition, but for this simple case, let's just try having the code simpler, amending just the following: 

stylesText += ( style + ':' + stylesDef[ style ] ).replace( semicolonFixRegex, ';' );

Changed 7 years ago by garry.yao

comment:3 Changed 7 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:4 Changed 7 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:5 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [4355].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy