Ticket #4784 (closed Bug: fixed)
Incorrect cursor position after delete table cells
| Reported by: | garry.yao | Owned by: | brooks |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | General | Version: | 3.0 |
| Keywords: | confirm Review+ | Cc: |
Description
Reproducing Procedures
- Open 'replacebyclass' sample page insert an default table.
- Click inside one of the table cell and open context menu on it.
- Click 'Cell->Delete Cells' to remove it.
- Actual Result: The cursor is not blinking at the same position agreed on all browsers, especially for some one the cursor is lost.
Attachments
Change History
comment:3 Changed 3 years ago by garry.yao
- Keywords Confirmed added
- Version changed from SVN (CKEditor) to 3.0
Similar with #4851.
comment:7 Changed 3 years ago by garry.yao
- Keywords Confirmed Review- added; Review? removed
- Load the following content and selection into editor in Firefox:
<table> <tr><td>[cell1]</td><td>cell2</td></tr> <tr><td>[cell3]</td></tr> </table>
- Delete the selected cells using context menu.
- Expected Result: Cursor is blinking inside 'cell2'.
- Actual Result: Cursor is not blinking any more.
comment:8 Changed 3 years ago by brooks
- Keywords Review? added; Confirmed Review- removed
update for 2 bugs:
- fix the algorithm for find the first focusable cell.
- if the last cell was deleted, delete the whole table.
comment:9 Changed 3 years ago by garry.yao
- Keywords Review- added; Review? removed
- fix the algorithm for find the first focusable cell.
With more robust logic right now, the patch increases the complexity of the cells deletion to O(n2) because of the 'indexOf' search, It's our common practice to use this way to filtering unwanted nodes, which could reduce to linear O(2n).
comment:10 follow-up: ↓ 11 Changed 3 years ago by brooks
- Keywords Review? added; Review- removed
nice suggest!
comment:11 in reply to: ↑ 10 Changed 3 years ago by garry.yao
- Keywords Review+ added; Review? removed
Congs! The codes looks much neater.
comment:12 Changed 3 years ago by brooks
- Status changed from assigned to closed
- Keywords confirm added
- Resolution set to fixed
fixed with 5352
Note: See
TracTickets for help on using
tickets.
