Kama skin: IFrame created in iframedialog plugin doesn't stretch to 100% height in FF3.5

[pekka]

When creating a new plugin that utilizes the iframedialog plugin, you have to pass a Pixel width and height:

CKEDITOR.plugins.add('dialog_name',{
    requires: ['iframedialog'],
    init:function(a){
        CKEDITOR.dialog.addIframe('dialog_name', 
                                  'Smiley',
                                  this.path+'lister.php',550,300,
                                  function(){/*oniframeload*/})
       // etc. etc.

iframedialog will assign those values to the dialog only and not to the iframe. The iframe gets assigned 100% width and height in the final source code.

In the kama skin, but not in the office2003 and v2 skins, this will lead to the iframe being only 160 Pixels tall in Firefox 3.5. It works as expected in Internet Explorer 8.

A fix that worked for me in Firefox 3.5 was to modify plugins/iframedialog/plugin.js and set a fixed width to the iframe:

CKEDITOR.dialog.addIframe = function( name, title, src, width, height, onContentLoad )
        {
            var element =
            {
                type : 'iframe',
                src : src,
                width : '100%',
                height : height  // CHANGED 
            };

The attached screen shot is using a customized template but checked with the original kama template as well.

Feel free to contact me on follow-up questions.

Thanks for providing this awesome product.

[pekka]

Screenshot of iframe in FF3.5

[pekka]

Oh and the doctype used is HTML 4.01 Transitional.

[garry.yao]

Confirmed with FF only.

[m.nguyen]

This bug happens on almost browser and skin.

[garry.yao]

Move to 3.2 since this bug not only affect iframe dialog plugin, but all dialogs' height in Firefox:

Environment

Firefox, Win7

Reproducing Procedures

1. Open any page sample, then open the 'Link' dialog;
2. Inspect the layout height of dialog contents element (td.cke_dialog_contents) with Firebug;

• Actual Result: The layouted height is 208;
• Expected Result: The layout height should be identical to defined minimum height, which is 230.

[m.nguyen]

Fixed with [4922].

[fredck]

I've reverted [4922] with [5199] because was breaking dialogs in IE Quirks.

[fredck]

To be less drastic, I've reimplemented [4922] with [5201], but avoiding it on IE quirks for now.

[m.nguyen]

New patch for IE quirks mode. This solution was a bit problem with smiley plugin, but this patch also fixed it.

[garry.yao]

Cong, that's a nice hack[[BR]] We should try to keep layout hacks inside CSS files and comment out the culprit.

[m.nguyen]

#5347 has been marked as dup

[m.nguyen]

Refixed with [5248].