Ticket #4932 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Collapse toolbar button visible but not usable on simple toolbars

Reported by: wwalc Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Toolbar Version: SVN (CKEditor) - OLD
Keywords: IBM Oracle Confirmed Review+ Cc: Pranav, Senthil, lisaj, JoeK, damo

Description

When using simple toolbar, like in the uicolor sample, there is a "collapse toolbar" arrow on the right side of the toolbar. Clicking on it does nothing.

Apparently it works when there are at least two rows of buttons. I think it could be hidden automatically when there is only one row of buttons.

Attachments

4932.patch (1.2 KB) - added by m.nguyen 4 years ago.
4932_2.patch (1.3 KB) - added by m.nguyen 4 years ago.
4932_3.patch (1.6 KB) - added by m.nguyen 4 years ago.
4932_4.patch (1.7 KB) - added by m.nguyen 4 years ago.

Change History

comment:1 Changed 4 years ago by alfonsoml

  • Keywords Oracle added
  • Cc Pranav, Senthil, lisaj added
  • Version set to 3.1
  • Type changed from New Feature to Bug
  • Milestone set to CKEditor 3.3

#5097 and #5037 have been marked as dups.

If people want to hide the collapse button they can do it in the configuration, but if they have left it enabled then it should work, so this is a bug.

comment:2 Changed 4 years ago by alfonsoml

  • Cc JoeK, damo added
  • Keywords IBM added

#5227 has been marked as dup

Changed 4 years ago by m.nguyen

comment:3 Changed 4 years ago by m.nguyen

  • Owner set to m.nguyen
  • Status changed from new to assigned
  • Keywords Review? added

Changed 4 years ago by m.nguyen

comment:4 Changed 4 years ago by fredck

  • Status changed from assigned to closed
  • Resolution set to worksforme
  • Milestone CKEditor 3.3 deleted

This one is working for me now with CKEditor 3.2.

comment:5 Changed 4 years ago by m.nguyen

  • Status changed from closed to reopened
  • Version changed from 3.1 to SVN (CKEditor)
  • Resolution worksforme deleted

#5251 has been marked as dup This bug still happen with simple toolbar on Chrome, Safari, Opera.

comment:6 Changed 4 years ago by m.nguyen

  • Keywords changed from IBM Oracle Confirmed Review? to IBM Oracle Confirmed Review? Review?
  • Milestone set to CKEditor 3.3

comment:7 Changed 4 years ago by m.nguyen

  • Keywords changed from IBM Oracle Confirmed Review? Review? to IBM Oracle Confirmed Review?

comment:8 Changed 4 years ago by garry.yao

How about 'min-height:1' just save couple of bytes more?

comment:9 Changed 4 years ago by garry.yao

  • Keywords Review- added; Review? removed

Note that a [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/skins/kama/toolbar.css#L416

previous fix] is already created for FF, it should be normalized as well.

Changed 4 years ago by m.nguyen

comment:10 Changed 4 years ago by m.nguyen

  • Keywords Review? added; Review- removed

comment:11 Changed 4 years ago by garry.yao

Could you tell me why the targeting browsers various in different skin files in 4932_3.patch?

comment:12 Changed 4 years ago by m.nguyen

Sorry, I didn't clear browser's cache when test it.

This bug happen when toolbar's offsetHeight always is zero in case it has one row of buttons. Then we check isVisible at line http://dev.fckeditor.net/browser/CKEditor/trunk/_source/core/dom/element.js#L759 return false value.

Changed 4 years ago by m.nguyen

comment:13 Changed 4 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:14 Changed 4 years ago by m.nguyen

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed with [5216].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy