Opened 15 years ago
Closed 15 years ago
#4932 closed Bug (fixed)
Collapse toolbar button visible but not usable on simple toolbars
| Reported by: | Wiktor Walc | Owned by: | Minh Nguyen |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | UI : Toolbar | Version: | SVN (CKEditor) - OLD |
| Keywords: | IBM Oracle Confirmed Review+ | Cc: | Pranav, Senthil, lisaj, Joe Kavanagh, Damian |
Description
When using simple toolbar, like in the uicolor sample, there is a "collapse toolbar" arrow on the right side of the toolbar. Clicking on it does nothing.
Apparently it works when there are at least two rows of buttons. I think it could be hidden automatically when there is only one row of buttons.
Attachments (4)
Change History (18)
comment:1 Changed 15 years ago by
| Cc: | Pranav Senthil lisaj added |
|---|---|
| Keywords: | Oracle added |
| Milestone: | → CKEditor 3.3 |
| Type: | New Feature → Bug |
| Version: | → 3.1 |
comment:2 Changed 15 years ago by
| Cc: | Joe Kavanagh Damian added |
|---|---|
| Keywords: | IBM added |
#5227 has been marked as dup
Changed 15 years ago by
| Attachment: | 4932.patch added |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Minh Nguyen |
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 4932_2.patch added |
|---|
comment:4 Changed 15 years ago by
| Milestone: | CKEditor 3.3 |
|---|---|
| Resolution: | → worksforme |
| Status: | assigned → closed |
This one is working for me now with CKEditor 3.2.
comment:5 Changed 15 years ago by
| Resolution: | worksforme |
|---|---|
| Status: | closed → reopened |
| Version: | 3.1 → SVN (CKEditor) |
#5251 has been marked as dup
This bug still happen with simple toolbar on Chrome, Safari, Opera.
comment:6 Changed 15 years ago by
| Keywords: | IBM Oracle Confirmed Review? → IBM Oracle Confirmed Review? Review? |
|---|---|
| Milestone: | → CKEditor 3.3 |
comment:7 Changed 15 years ago by
| Keywords: | IBM Oracle Confirmed Review? Review? → IBM Oracle Confirmed Review? |
|---|
comment:9 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Note that a [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/skins/kama/toolbar.css#L416
previous fix] is already created for FF, it should be normalized as well.
Changed 15 years ago by
| Attachment: | 4932_3.patch added |
|---|
comment:10 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:11 Changed 15 years ago by
Could you tell me why the targeting browsers various in different skin files in 4932_3.patch?
comment:12 Changed 15 years ago by
Sorry, I didn't clear browser's cache when test it.
This bug happen when toolbar's offsetHeight always is zero in case it has one row of buttons. Then we check isVisible at line http://dev.fckeditor.net/browser/CKEditor/trunk/_source/core/dom/element.js#L759 return false value.
Changed 15 years ago by
| Attachment: | 4932_4.patch added |
|---|
comment:13 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
#5097 and #5037 have been marked as dups.
If people want to hide the collapse button they can do it in the configuration, but if they have left it enabled then it should work, so this is a bug.