Opened 6 years ago

Closed 5 years ago

#4932 closed Bug (fixed)

Collapse toolbar button visible but not usable on simple toolbars

Reported by: wwalc Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Toolbar Version: SVN (CKEditor) - OLD
Keywords: IBM Oracle Confirmed Review+ Cc: Pranav, Senthil, lisaj, JoeK, damo

Description

When using simple toolbar, like in the uicolor sample, there is a "collapse toolbar" arrow on the right side of the toolbar. Clicking on it does nothing.

Apparently it works when there are at least two rows of buttons. I think it could be hidden automatically when there is only one row of buttons.

Attachments (4)

4932.patch (1.2 KB) - added by m.nguyen 5 years ago.
4932_2.patch (1.3 KB) - added by m.nguyen 5 years ago.
4932_3.patch (1.6 KB) - added by m.nguyen 5 years ago.
4932_4.patch (1.7 KB) - added by m.nguyen 5 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 5 years ago by alfonsoml

  • Cc Pranav Senthil lisaj added
  • Keywords Oracle added
  • Milestone set to CKEditor 3.3
  • Type changed from New Feature to Bug
  • Version set to 3.1

#5097 and #5037 have been marked as dups.

If people want to hide the collapse button they can do it in the configuration, but if they have left it enabled then it should work, so this is a bug.

comment:2 Changed 5 years ago by alfonsoml

  • Cc JoeK damo added
  • Keywords IBM added

#5227 has been marked as dup

Changed 5 years ago by m.nguyen

comment:3 Changed 5 years ago by m.nguyen

  • Keywords Review? added
  • Owner set to m.nguyen
  • Status changed from new to assigned

Changed 5 years ago by m.nguyen

comment:4 Changed 5 years ago by fredck

  • Milestone CKEditor 3.3 deleted
  • Resolution set to worksforme
  • Status changed from assigned to closed

This one is working for me now with CKEditor 3.2.

comment:5 Changed 5 years ago by m.nguyen

  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Version changed from 3.1 to SVN (CKEditor)

#5251 has been marked as dup This bug still happen with simple toolbar on Chrome, Safari, Opera.

comment:6 Changed 5 years ago by m.nguyen

  • Keywords changed from IBM Oracle Confirmed Review? to IBM Oracle Confirmed Review? Review?
  • Milestone set to CKEditor 3.3

comment:7 Changed 5 years ago by m.nguyen

  • Keywords changed from IBM Oracle Confirmed Review? Review? to IBM Oracle Confirmed Review?

comment:8 Changed 5 years ago by garry.yao

How about 'min-height:1' just save couple of bytes more?

comment:9 Changed 5 years ago by garry.yao

  • Keywords Review- added; Review? removed

Note that a [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/skins/kama/toolbar.css#L416

previous fix] is already created for FF, it should be normalized as well.

Changed 5 years ago by m.nguyen

comment:10 Changed 5 years ago by m.nguyen

  • Keywords Review? added; Review- removed

comment:11 Changed 5 years ago by garry.yao

Could you tell me why the targeting browsers various in different skin files in 4932_3.patch?

comment:12 Changed 5 years ago by m.nguyen

Sorry, I didn't clear browser's cache when test it.

This bug happen when toolbar's offsetHeight always is zero in case it has one row of buttons. Then we check isVisible at line http://dev.fckeditor.net/browser/CKEditor/trunk/_source/core/dom/element.js#L759 return false value.

Changed 5 years ago by m.nguyen

comment:13 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:14 Changed 5 years ago by m.nguyen

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed with [5216].

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy