Browser Server in Link tab of Image Properties dialog links to the wrong page

[Ben]

When you click the Browser Server button on the Link tab of the Image Properties dialog, it takes you to the filebrowserImageBrowseUrl...

Shouldn't it take you to the filebrowserBrowseUrl?

[Wiktor Walc]

Confirmed, in FCKeditor the "Browse Server" button opened file browser with all resource types (filebrowserBrowseUrl) in the "link" tab.

Right now filebrowser plugin is using only dialog name in attachFileBrowser() function. To solve this issue, the filebrowser definition attribute schema used in dialogs should be extended.

Current definition in image dialog (Link tab):

filebrowser : 'info:txtUrl'

we can extend it into something like

filebrowser : 'info:txtUrl:filebrowserBrowseUrl'

where the last part of the definition is optional. If the last part is defined, it has higher priority than editor.config[ 'filebrowser' + ucFirst( dialogName ) + 'BrowseUrl' ].

[Wiktor Walc]

Ok... forget my last comment.

In attached patch the solution is much simpler. In the image dialog definition we're simply setting the filebrowser.url configuration option to correct url:

• config.filebrowserImageBrowseLinkUrl - new configuration option, this way developer can precisely set what url should be shown in the "Link" tab in the Image dialog
• config.filebrowserBrowseUrl - if filebrowserImageBrowseLinkUrl is not set, this will be the default value. It means that CKEditor will now by default work like FCKeditor (it will show all resource types instead of showing only "Images").

[Frederico Caldeira Knabben]

We need documentation for the configuration option.

[Wiktor Walc]

Fixed with [5096].

[Tony]

Nice job wwalc, confirming that your patch is working here.

Many thanks, Tony