Ticket #4987 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Browser Server in Link tab of Image Properties dialog links to the wrong page

Reported by: bensinclair1 Owned by: wwalc
Priority: Normal Milestone: CKEditor 3.2
Component: UI : Dialogs Version: 3.0
Keywords: Confirmed Review+ Doc Cc:

Description

When you click the Browser Server button on the Link tab of the Image Properties dialog, it takes you to the filebrowserImageBrowseUrl...

Shouldn't it take you to the filebrowserBrowseUrl?

Attachments

4987.patch (668 bytes) - added by wwalc 4 years ago.

Change History

comment:1 Changed 5 years ago by wwalc

  • Owner set to wwalc
  • Keywords Confirmed added
  • Version changed from 3.1 to 3.0
  • Milestone set to CKEditor 3.2

Confirmed, in FCKeditor the "Browse Server" button opened file browser with all resource types (filebrowserBrowseUrl) in the "link" tab.

Right now filebrowser plugin is using only dialog name in attachFileBrowser() function. To solve this issue, the filebrowser definition attribute schema used in dialogs should be extended.

Current definition in image dialog (Link tab):

filebrowser : 'info:txtUrl'

we can extend it into something like

filebrowser : 'info:txtUrl:filebrowserBrowseUrl'

where the last part of the definition is optional. If the last part is defined, it has higher priority than editor.config[ 'filebrowser' + ucFirst( dialogName ) + 'BrowseUrl' ].

Changed 4 years ago by wwalc

comment:2 Changed 4 years ago by wwalc

  • Keywords Review? added

Ok... forget my last comment.

In attached patch the solution is much simpler. In the image dialog definition we're simply setting the filebrowser.url configuration option to correct url:

  • config.filebrowserImageBrowseLinkUrl - new configuration option, this way developer can precisely set what url should be shown in the "Link" tab in the Image dialog
  • config.filebrowserBrowseUrl - if filebrowserImageBrowseLinkUrl is not set, this will be the default value. It means that CKEditor will now by default work like FCKeditor (it will show all resource types instead of showing only "Images").

comment:3 Changed 4 years ago by fredck

  • Keywords Review+ Doc? added; Review? removed

We need documentation for the configuration option.

comment:4 Changed 4 years ago by wwalc

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [5096].

comment:5 Changed 4 years ago by tony

Nice job wwalc, confirming that your patch is working here.

Many thanks, Tony

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy