Opened 14 years ago

Closed 14 years ago

#4988 closed Bug (fixed)

Safari breaks when pasting with forcePasteAsPlainText = true

Reported by: Frederico Caldeira Knabben Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: CKEditor 3.2
Component: Core : Pasting Version: 3.1
Keywords: Safari Confirmed Review+ Cc: diego@…

Description

When pasting with Safari and forcePasteAsPlainText = true in the settings, the browser breaks and shutdown completely.

Confirmed with Safari 3.2.2 Win, and also reported here.

Attachments (1)

4988.patch (1.2 KB) - added by Alfonso Martínez de Lizarrondo 14 years ago.
Proposed patch

Download all attachments as: .zip

Change History (14)

comment:1 Changed 14 years ago by Frederico Caldeira Knabben

WFM with Chrome 4.

comment:2 Changed 14 years ago by Diego Caravana

Cc: diego@… added

Confirmed also in Safari 4.0.4 Mac but without the nasty crash, simply it doesn't work (if you insist and try to paste more the one time, one or more textareas for each paste appears inside the editor).

comment:3 Changed 14 years ago by Diego Caravana

And, yes, it works in Chrome 4 Mac (it seems a Safari-only problem, apart from webkit).

comment:4 Changed 14 years ago by Garry Yao

WFM with Safari4/Win.

comment:5 Changed 14 years ago by Garry Yao

Priority: HighNormal

WFM also with Safari3/Win, seems for me a Mac-Safari-only problem.

comment:6 Changed 14 years ago by Diego Caravana

Yes, I confirm that the bug doesn't affect Safari 4.0.4 WIN, but does affect the same Safari version on Mac.

comment:7 Changed 14 years ago by starnox

Confirmed in Safari 4.0.4/Mac OS 10.6.2.

Single paste results in a blank space being inserted. Further pastes result in textareas appearing within the editor.

comment:8 Changed 14 years ago by Frederico Caldeira Knabben

This one may be related to #5095, which is an internal browser bug.

comment:9 Changed 14 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.2CKEditor 3.3

Changed 14 years ago by Alfonso Martínez de Lizarrondo

Attachment: 4988.patch added

Proposed patch

comment:10 Changed 14 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

In Webkit it's possible to get the content of the clipboard as plain text without any hack, so the patch uses that approach.

I've included also a change in the registration of the event that fixes #5095 as that might make easier to review all the code.

And after applying the patch it seems that #5144 is also fixed, although that bug is a little elusive and sometimes seems to work (or maybe it's problems with the cache)

comment:11 Changed 14 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed
Milestone: CKEditor 3.3CKEditor 3.2

Great job! Feel free to close #5144 also (please add changelog entries for both tickets).

comment:12 Changed 14 years ago by Frederico Caldeira Knabben

#5095 can be closed as well.

comment:13 Changed 14 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [5118]

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy