Ticket #4993 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Cannot change image alignment back to "not set" without reopening a dialog

Reported by: wwalc Owned by: m.nguyen
Priority: Normal Milestone: CKEditor 3.2
Component: General Version: 3.0.2
Keywords: Confirmed Review+ Cc:

Description

When embedding an image, if you change the alignment dropdown to either left or right, you can't change it back to "<not set>" without reopening the dialog.

Steps to reproduce

  • Start with
    <h1>
    	<img alt="" src="http://a.cksource.com/c/1/inc/img/fireworks.png" />Happy New Year!</h1>
    <p>
    	The CKSource team wishes a <strong>wonderful and happy New Year</strong> to everybody around the globe!</p>
    
  • open image dialog, change alignment to right, change alignment to <not set>
  • result:
    <img alt="" src="http://a.cksource.com/c/1/inc/img/fireworks.png" style="float: right;" />
    

(float: right has not been removed).

This bug has been introduced in [4685] (#4246).

Attachments

4993.patch (669 bytes) - added by m.nguyen 5 years ago.

Change History

Changed 5 years ago by m.nguyen

comment:1 Changed 5 years ago by m.nguyen

  • Owner set to m.nguyen
  • Status changed from new to assigned
  • Keywords Review? added

comment:2 Changed 5 years ago by m.nguyen

In this case we don't need using method this.isChanged() in condition.

comment:3 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

That's true, we don't need to retain float values that are not supported.

comment:4 Changed 5 years ago by m.nguyen

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [4994].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy