FF: Copy/paste of an image from same domain as CKeditor changes URL to relative URL

[Omkar]

This issue occurs only in Firefox.

To reproduce:

1. Go to an instance of CKEditor (eg ​http://drupal.ckeditor.com/)
2. Add an image that uses the same domain (eg ​http://drupal.ckeditor.com/images/logo-ie.png)
3. Check image properties in CKEditor to verify the full URL is listed
4. Copy and paste the image
5. Check image properties on the pasted image - URL has been modified

See attached screenshot.

My limited testing of a couple OSes and a few browsers shows that this issue occurs only in Firefox:

OS: OSX 10.6.2

Issue occurs in Firefox 3.5.8 (see screenshot) Issue does not occur in Chrome 5.0.307.9 beta Issue does not occur in Safari 4.0.4 (6531.21.10)

OS: Windows XP

Issue occurs in Firefox 3.5.8 Issue does not occur in IE 8.0.6001.18702

[Omkar]

Screenshot of the URL being modified in Firefox 3.5.8

[laurentl]

OS: Linux

Issue occurs in Firefox 3.6 OK on Chromium 5.0.342.9 (43360)

OS: Windows XP

Issue occurs in Firefox 3.6 Issue occurs in IE 7

[Alfonso Martínez de Lizarrondo]

#5665 has been marked as dup

[Jonathon Sim]

This bug also occurs on the latest nightly releases (to easily test it switch to source mode and enter "<img src="/test/test.png">" then switch back and cut-and-paste the resulting image - when you switch to source mode you will see it is now a relative url)

The issue is that firefox rewrites the image src attribute when you paste them, making them relative to the path to the editor (which may not be correct when you view the HTML elsewhere).

We have had success with the attached patch to htmldataprocessor which rewrites the src back to the _cke_saved_src

[Jonathon Sim]

Fixed version of the patch

[Jonathon Sim]

The original patch unfortunately didn't fix it (I'm not sure why in my original testing I though it did), but I've uploaded a fixed version that does.

[Frederico Caldeira Knabben]

The fact is that, theoretically, the original _cke_saved_src attribute should be also pasted, and then used by the editor in the image dialog and when outputting data. I think the default data processing on pasting is instead overwritting the already available _cke_saved_src attribute, replacing it with the wrong src. This is the thing to be fixed.

[Jonathon Sim]

That is exactly what's happening (I had to trace this through to fix it in our setup). I thought it was probably a bit ambitious for me to try to "fix" it without really knowing how it works, the attached patch is at least less invasive

FYI what I found was :

• the cke_saved_src is pasted correctly (my patch works by copying it back into the img src attribute on paste), but firefox has munged the src attribute
• When you paste the "paste" event handler in clipboard/plugin.js calls

editor.insertHtml( data[ 'html' ] );

which triggers an event "inserthtml" which runs CKEDITOR.htmlDataProcessor.toHtml in htmldataprocessor/plugin.js, which runs this:

	function protectAttributes( html )
	{
		return html.replace( protectAttributeRegex, '$& _cke_saved_$1' );
	}

which overrides the cke_saved_src with the modified one firefox just pasted.

I assume though that its probably not appropriate though to just skip protectAttributes for pasted HTML (it wasn't necessarily pasted from within a ckeditor instance) - perhaps if it were modified not to overwrite existing cke_saved_src attributes in pasted code?

[Frederico Caldeira Knabben]

You found the root of the problem. My suggestion is changing the data processor so it'll create the cke_saved_src attribute only if it doesn't exist.

[Charlie]

Another post which I believe might be related to this problem? Could serve as a good test case as well.

​http://cksource.com/forums/viewtopic.php?f=11&t=19445

[Frederico Caldeira Knabben]

There is no need to have the entire _cke_saved_src attribute check, including its value, in the findSavedSrcRegex regex. It can be simpler (less code) and faster, like /\s_cke_saved_src\s*=/.

[Joe]

Thanks Saare, but this patch doesn't fix the problem either.

[Rick]

The same problem with "href" attribute (<a> tag). Tried to apply patch, but it doesn't help :(

[Tobiasz Cudnik]

I'm giving R+ as ticket issue is fixed. If you're having similar issues with other attributes please open a new ticket for them.

[Sa'ar Zac Elias]

Fixed with [5878].

[rocing]

Problems still exist

[Sa'ar Zac Elias]

#6320 is a DUP.

[Jonathon Sim]

Unfortunately, I can still reproduce this problem on the nightly build using firefox 3.6.10

• Load ​http://nightly.ckeditor.com/5888/_samples/replacebyclass.html
• Click the insert image icon and insert "/test/fake.gif" (you can also just insert this in the source)
• Copy and paste the image

The url of the pasted image becomes <img src="../../test/fake.gif">

[Alfonso Martínez de Lizarrondo]

The problems with latests Firefoxes is #6275