Ticket #5278 (closed Bug: fixed)
Link Dialog / Popup Name / Add validation to check for bad window names
| Reported by: | toga98 | Owned by: | m.nguyen |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | General | Version: | 3.2 |
| Keywords: | Confirmed IE Review+ | Cc: |
Description
Add validation to check for bad window names.
For example, if you type in a name with spaces it will not work in MSIE.
To reproduce in MSIE:
* Create a Link to "http://google.com" * In the link dialog. ** Go to the target tab and select <popup window> as a target ** Type in "one two" as the Popup Window Name without the quotes. * Press OK in the Link dialog. * Preview the content. * Click the google link in the preview. * The link is expected to open in a new window / window as named. Instead the link opens in the current window.
Attachments
Change History
comment:2 Changed 3 years ago by m.nguyen
- Owner set to m.nguyen
- Keywords Review? added
- Version set to 3.2
- Status changed from new to assigned
- Milestone set to CKEditor 3.3
comment:4 Changed 3 years ago by alfonsoml
- Keywords Review- added; Review? removed
Instead of giving a warning I would rather do it automatically like in V2:
var sWindowName = "'" + GetE('txtPopupName').value.replace(/\W/gi, "") + "'" ;
We know what the problem is, so we should handle it automatically without any extra job from the user.
comment:7 Changed 3 years ago by garry.yao
I would vote for Minh's original approach, the auto fixing looks strange.
Note: See
TracTickets for help on using
tickets.
