Opened 14 years ago
Last modified 10 years ago
#5317 pending Task
Create tool to improve detection of non released memory
| Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | QA | Version: | 3.0 |
| Keywords: | Cc: |
Description
Follow up of #4555
It's not the typical "memory leak" problem present in the browsers, but it's easy to store data in a way that it isn't released after one instance is destroyed in an AJAX way, and that means more and more memory use, so it's in the end a memory leak.
In the previous bug we have cleaned up the main codeline, but there are other parts that will have to be reviewed and instead of trying to dig into every plugin we must try to find an automated way that help us diagnose where are the problems.
Attachments (2)
Change History (10)
Changed 14 years ago by
| Attachment: | 5317.patch added |
|---|
comment:1 Changed 14 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Alfonso Martínez de Lizarrondo |
| Status: | new → assigned |
Ok, this version I think that is able to catch all the leaks fixed in #4555.
A word of caution: disable firebug before using it or the script might give timeouts trying to store all the callstacks.
To test it disable any of the fixes of #4555 and check that it's properly reported here. Start the test, use the editor as you want and then click the end test to check if it has detected any problem.
comment:2 Changed 13 years ago by
| Milestone: | → CKEditor 3.6 |
|---|---|
| Version: | → 3.0 |
The _dev folder is not included in release anyway, so having there an already created tool that can help us in tracing issues with memory sounds good.
comment:3 Changed 13 years ago by
| Status: | review → review_failed |
|---|
The tool reports interference object changes like "CKEDITOR.ui._" and "CKEDITOR.config" which leads to actually no leak.
comment:4 Changed 13 years ago by
| Milestone: | CKEditor 3.6 |
|---|
It definitely should not block the 3.6 release, so I'm removing the milestone. Let's simply add the tool to the _dev folder once it works as expected
comment:5 follow-up: 8 Changed 10 years ago by
Is this tool needed any more? Doesn't Chrome's memory profiling do the same job?
comment:6 Changed 10 years ago by
| Owner: | Alfonso Martínez de Lizarrondo deleted |
|---|---|
| Status: | review_failed → new |
comment:7 Changed 10 years ago by
| Status: | new → pending |
|---|
comment:8 Changed 10 years ago by
Replying to Reinmar:
Is this tool needed any more? Doesn't Chrome's memory profiling do the same job?
Things have changed a lot in these four years, at that time there was no memory profiling tools like these days.
Chrome's profiling would help to detect problems in the common code but not in the code paths that are executed by other browsers, so remember that any kind of tests should be done on each browser.
If something like this is implemented, I think that bugs like http://dev.ckeditor.com/ticket/10731 could have been detected earlier.
Of course, as CKEditor has changed so much, the current proposal is worthless and if anything is done is should be created almost from scratch.
First version