Ticket #5500 (closed Bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Missing attributes of Text Field

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.1
Keywords: IE Cc:

Description

Environment

All IE versions

Reproducing Procedures

  1. Open any of the sample page;
  2. Insert a text field with all fields filled;
  3. Switch to 'Source' mode and switch back;
  4. Open 'Text Field' dialog through context menu;
  • Actual Result: 'Value' field value is missing.

Attachments

5500.patch (438 bytes) - added by m.nguyen 4 years ago.
we had missed return value in case the type of input is 'text'
5500_2.patch (4.4 KB) - added by garry.yao 3 years ago.
5500_3.patch (4.9 KB) - added by garry.yao 3 years ago.

Change History

comment:1 Changed 4 years ago by m.nguyen

  • Keywords IE Confirmed added

Changed 4 years ago by m.nguyen

we had missed return value in case the type of input is 'text'

comment:2 Changed 4 years ago by m.nguyen

  • Status changed from new to assigned
  • Owner set to m.nguyen
  • Keywords Review? added

comment:3 Changed 3 years ago by wwalc

  • Keywords IE added; IEConfirmed removed
  • Milestone set to CKEditor 3.5.1

comment:4 Changed 3 years ago by Saare

WFM on trunk using the patch from #6646. Let's wait for that ticket to be resolved.

Changed 3 years ago by garry.yao

comment:5 Changed 3 years ago by garry.yao

This problem (related to input element r/w in IE7) is not related to #6646, affects both textfield and button dialogs.

comment:6 Changed 3 years ago by garry.yao

  • Owner changed from m.nguyen to garry.yao

comment:7 Changed 3 years ago by Saare

  • Status changed from review to review_failed
  • The patch fixes the problem on native IE7 while fails on IE9's IE7 mode.
  • Creating a button on a native IE7 results in a JS error.
  • [IE9's IE7 mode] Create a button. Open the button dialog through a context menu. The value field is empty.
  • Let's avoid changing the id of dialog fields for backwards compatibility.

Changed 3 years ago by garry.yao

comment:8 Changed 3 years ago by garry.yao

  • Status changed from review_failed to review

The field is badly named, prefer a correction over back-compat here.

comment:9 Changed 3 years ago by Saare

  • Status changed from review to review_passed

comment:10 Changed 3 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6314].

comment:11 in reply to: ↑ description Changed 3 years ago by krst

  • Status changed from closed to reopened
  • Resolution fixed deleted

Replying to garry.yao:

Environment

All IE versions

Reproducing Procedures

  1. Open any of the sample page;
  2. Insert a text field with all fields filled;
  3. Switch to 'Source' mode and switch back;
  4. Open 'Text Field' dialog through context menu;
  • Actual Result: 'Value' field value is missing.

After switching to Source andv back to wysiwyg, Value field, still is cleared (IE6/7)

comment:12 Changed 3 years ago by krst

Update to comment 11 - Setting of cleared field is Password. I think, when user enters default value into content, it should be present for both Password ot Text fields (as the dialog window allows).

comment:13 Changed 3 years ago by alfonsoml

Setting a default value for a Password field doesn't make sense. I think that a new ticket should be opened to disable that possibility.

comment:14 Changed 3 years ago by krst

Under Opera, Firefox, Chrome - password default value is remembered. CKEditor should work similar under all browsers, that is why I reopened this ticket.
@Alfonso - I added new ticket #7042 as You suggested, so the discussion will continue there.

comment:15 Changed 3 years ago by garry.yao

  • Status changed from reopened to closed
  • Resolution set to fixed

Always avoid open fixed (committed) ticket for regressions, this's even not a regression.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy