Opened 5 years ago

Closed 5 years ago

#6646 closed Bug (fixed)

text inputs and areas lack context menu if they are present in the initial content

Reported by: alfonsoml Owned by: Saare
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.4
Keywords: Cc:

Description

Follow up from #6046

That ticket fixed the context menu for those elements when they are inserted, but if they are present in the original content, then the isReadOnly() check returns the element and so they aren't editable.

Reproduction steps:

  1. Insert a text input, check that the context menu for editing it appears.
  2. Switch to source and back to design.
  3. The context menu entry is missing.

(be careful if checking with IE due to #5522)

Attachments (2)

6646.patch (2.6 KB) - added by garry.yao 5 years ago.
6646_2.patch (2.6 KB) - added by Saare 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by Saare

  • Status changed from new to confirmed

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

  • Milestone set to CKEditor 3.5.1
  • Owner set to garry.yao
  • Status changed from confirmed to review

One thing need to be reviewed is whether it works with [some hacks http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/forms/dialogs/textfield.js#L177 ] we introduced in IE for inputs.

comment:3 follow-up: Changed 5 years ago by tobiasz.cudnik

  • Status changed from review to review_failed

The Value field is empty when trying to edit the control.

Changed 5 years ago by Saare

comment:4 Changed 5 years ago by Saare

  • Owner changed from garry.yao to Saare
  • Status changed from review_failed to review

comment:5 Changed 5 years ago by garry.yao

  • Status changed from review to review_passed

comment:6 in reply to: ↑ 3 Changed 5 years ago by garry.yao

Replying to tobiasz.cudnik:

The Value field is empty when trying to edit the control.

Missing value attribute is an known IE7 bug and we've already had a ticket for it.

comment:7 Changed 5 years ago by Saare

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [6289].

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy