Opened 7 years ago

Closed 7 years ago

#5567 closed Bug (fixed)

Remove inline style not joining siblings

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: Core : Styles Version: 3.0
Keywords: Confirmed IE Review+ Cc:

Description (last modified by garry.yao)

Environment

IE8

Reproducing Procedures

  1. Open any of the sample page;
  2. Load the following content in editor;
    <p>
    	Some sample text</p>
    
  3. Select 'Some sample' and apply the 'Bold' style;
  4. Select 'sample text' and apply the 'Italic' style;
  5. Select 'sample' and remove the 'Bold' style;
  6. Swtich to Source mode and check the output.
    • Actual Result:
      <p><strong>Some </strong><em>sample</em><em> text</em></p>
      
    • Expected Result:
      <p><strong>Some </strong><em>sample text</em></p>
      

Attachments (3)

5567.patch (5.6 KB) - added by garry.yao 7 years ago.
5567_2.patch (5.4 KB) - added by garry.yao 7 years ago.
5567_3.patch (5.3 KB) - added by garry.yao 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by garry.yao

  • Description modified (diff)

comment:2 Changed 7 years ago by garry.yao

  • Description modified (diff)
  • Keywords IE added
  • Owner set to garry.yao
  • Status changed from new to assigned

Affects IE only.

comment:3 Changed 7 years ago by garry.yao

  • Keywords Review? added

comment:4 Changed 7 years ago by garry.yao

Another case for this problem:

  1. Load the following content with selection:
    <strong>some <a href=" http://ckeditor.com">[sample ]</a></strong><a href=" http://ckeditor.com">link</a>
    
  2. Remove 'Bold' style from the selection.
    • Actual Result: The link element is not merged on output.

Changed 7 years ago by garry.yao

Changed 7 years ago by garry.yao

comment:5 Changed 7 years ago by alfonsoml

  • Keywords Review- added; Review? removed

The "ignore" variable is only set, it isn't used in any other place so it can be removed.

The check for "Merge empty links but not anchors." isn't needed. The merging should really help if there are two anchors together with the same name, that's a problem (only one of them will work) and merging them will fix the problem.

comment:6 Changed 7 years ago by garry.yao

  • Keywords Review? added; Review- removed

The "ignore" variable is only set...

Used on L913.

Changed 7 years ago by garry.yao

comment:7 Changed 7 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

My comment was just that it's set on L913 but it isn't used in any other place so we can skip the assignment.

Fix that before committing.

comment:8 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5396].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy