Opened 15 years ago
Closed 15 years ago
#5567 closed Bug (fixed)
Remove inline style not joining siblings
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | Core : Styles | Version: | 3.0 |
Keywords: | Confirmed IE Review+ | Cc: |
Description (last modified by )
Environment
IE8
Reproducing Procedures
- Open any of the sample page;
- Load the following content in editor;
<p> Some sample text</p>
- Select 'Some sample' and apply the 'Bold' style;
- Select 'sample text' and apply the 'Italic' style;
- Select 'sample' and remove the 'Bold' style;
- Swtich to Source mode and check the output.
- Actual Result:
<p><strong>Some </strong><em>sample</em><em> text</em></p>
- Expected Result:
<p><strong>Some </strong><em>sample text</em></p>
- Actual Result:
Attachments (3)
Change History (11)
comment:1 Changed 15 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 15 years ago by
Description: | modified (diff) |
---|---|
Keywords: | IE added |
Owner: | set to Garry Yao |
Status: | new → assigned |
comment:3 Changed 15 years ago by
Keywords: | Review? added |
---|
comment:4 Changed 15 years ago by
Another case for this problem:
- Load the following content with selection:
<strong>some <a href=" http://ckeditor.com">[sample ]</a></strong><a href=" http://ckeditor.com">link</a>
- Remove 'Bold' style from the selection.
- Actual Result: The link element is not merged on output.
Changed 15 years ago by
Attachment: | 5567.patch added |
---|
Changed 15 years ago by
Attachment: | 5567_2.patch added |
---|
comment:5 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
The "ignore" variable is only set, it isn't used in any other place so it can be removed.
The check for "Merge empty links but not anchors." isn't needed. The merging should really help if there are two anchors together with the same name, that's a problem (only one of them will work) and merging them will fix the problem.
comment:6 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
The "ignore" variable is only set...
Used on L913.
Changed 15 years ago by
Attachment: | 5567_3.patch added |
---|
comment:7 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
My comment was just that it's set on L913 but it isn't used in any other place so we can skip the assignment.
Fix that before committing.
Affects IE only.